Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(481)

Issue 7867007: content: Resubmit "Move constrained html windows to TabContentsWrapper." (Closed)

Created:
9 years, 3 months ago by Elliot Glaysher
Modified:
9 years, 3 months ago
CC:
chromium-reviews, Paweł Hajdan Jr.
Visibility:
Public.

Description

content: Resubmit "Move constrained html windows to TabContentsWrapper." Now with fix to midair collision with chromeos work. BUG=95257 TEST=compiles Previous Review URL: http://codereview.chromium.org/7860008 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=100580

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -21 lines) Patch
M chrome/browser/ui/cocoa/constrained_html_delegate_mac.mm View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/constrained_html_delegate_gtk.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/login/login_prompt_ui.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/constrained_html_delegate_gtk.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/constrained_html_delegate_views.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/collected_cookies_ui_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/constrained_html_ui.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/constrained_html_ui_browsertest.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/repost_form_warning_ui.cc View 2 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Elliot Glaysher
Same patch can be rubberstamped. Only file changed is chrome/browser/ui/webui/repost_form_warning_ui.cc which was a midair collision.
9 years, 3 months ago (2011-09-09 20:13:43 UTC) #1
jam
lgtm
9 years, 3 months ago (2011-09-09 20:47:01 UTC) #2
commit-bot: I haz the power
9 years, 3 months ago (2011-09-10 06:47:39 UTC) #3
Change committed as 100580

Powered by Google App Engine
This is Rietveld 408576698