Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 7866043: Prevent redirector from returning the current module in cases where it fails to look up the first... (Closed)

Created:
9 years, 3 months ago by robertshield
Modified:
9 years, 3 months ago
Reviewers:
grt (UTC plus 2)
CC:
chromium-reviews, amit
Visibility:
Public.

Description

Prevent redirector from returning the current module in cases where it fails to look up the first module in. This prevents a bug that can cause user-level Chrome Frame to redirect to itself when a system-level Chrome Frame is present. BUG=96016 TEST=Upgrade a user-level CF install to a system-level CF install while user-level CF is rendering. Observe that the current explorer instance does not hang when new CF tabs are created. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=100904

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 3

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -23 lines) Patch
M chrome/installer/test/alternate_version_generator.cc View 1 2 chunks +17 lines, -1 line 0 comments Download
M chrome_frame/dll_redirector.h View 3 chunks +10 lines, -5 lines 0 comments Download
M chrome_frame/dll_redirector.cc View 1 2 6 chunks +15 lines, -16 lines 0 comments Download
M chrome_frame/test/dll_redirector_test.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
robertshield
9 years, 3 months ago (2011-09-12 14:39:21 UTC) #1
grt (UTC plus 2)
LGTM with one small debug logging nit. http://codereview.chromium.org/7866043/diff/4001/chrome/installer/test/alternate_version_generator.cc File chrome/installer/test/alternate_version_generator.cc (left): http://codereview.chromium.org/7866043/diff/4001/chrome/installer/test/alternate_version_generator.cc#oldcode339 chrome/installer/test/alternate_version_generator.cc:339: if (image_handle.Get() ...
9 years, 3 months ago (2011-09-12 17:27:15 UTC) #2
robertshield
9 years, 3 months ago (2011-09-12 17:55:48 UTC) #3
Thanks!

http://codereview.chromium.org/7866043/diff/4001/chrome_frame/dll_redirector.cc
File chrome_frame/dll_redirector.cc (right):

http://codereview.chromium.org/7866043/diff/4001/chrome_frame/dll_redirector....
chrome_frame/dll_redirector.cc:234: DPLOG(ERROR) << "DllRedirector: Could not
get address of "
On 2011/09/12 17:27:15, grt wrote:
> DPLOG_IF(ERROR, !proc_ptr) << ...

You and your fancy macros..

Powered by Google App Engine
This is Rietveld 408576698