Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10382)

Unified Diff: chrome_frame/dll_redirector.h

Issue 7866043: Prevent redirector from returning the current module in cases where it fails to look up the first... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/installer/test/alternate_version_generator.cc ('k') | chrome_frame/dll_redirector.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome_frame/dll_redirector.h
===================================================================
--- chrome_frame/dll_redirector.h (revision 100136)
+++ chrome_frame/dll_redirector.h (working copy)
@@ -2,11 +2,12 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef CHROME_FRAME_MODULE_UTILS_H_
-#define CHROME_FRAME_MODULE_UTILS_H_
+#ifndef CHROME_FRAME_DLL_REDIRECTOR_H_
+#define CHROME_FRAME_DLL_REDIRECTOR_H_
#include <ObjBase.h>
#include <windows.h>
+#include <string>
#include "base/basictypes.h"
#include "base/memory/scoped_ptr.h"
@@ -49,8 +50,12 @@
void DllRedirector::UnregisterAsFirstCFModule();
// Helper function to return the DllGetClassObject function pointer from
- // the given module. On success, the return value is non-null and module
- // will have had its reference count incremented.
+ // the given module. This function will return NULL unless
+ // RegisterAsFirstCFModule has been called first and returned false
+ // indicating that another module was first in.
+ //
+ // On success, the return value is non-null and the first-in module will have
+ // had its reference count incremented.
LPFNGETCLASSOBJECT GetDllGetClassObjectPtr();
protected:
@@ -101,4 +106,4 @@
DISALLOW_COPY_AND_ASSIGN(DllRedirector);
};
-#endif // CHROME_FRAME_MODULE_UTILS_H_
+#endif // CHROME_FRAME_DLL_REDIRECTOR_H_
« no previous file with comments | « chrome/installer/test/alternate_version_generator.cc ('k') | chrome_frame/dll_redirector.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698