Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Issue 7864019: Fix a race in BrowserRenderProcessHost::FastShutdownIfPossible (Closed)

Created:
9 years, 3 months ago by achuithb
Modified:
9 years, 3 months ago
Reviewers:
oshima, Charlie Reis, jam
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Fix a race where Init gets called right after FastShutdownIfPossible before channel_ has been reset by OnChannelError after a round-trip. BUG=chromium-os:18390 TEST=Open a new tab on cros. Close all other tabs. Navigate to google.com. Close the tab. Should no longer see the sad tab. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=100765

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M content/browser/renderer_host/browser_render_process_host.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/renderer_host/browser_render_process_host.cc View 1 2 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
achuithb
Thanks for pointing me in the right direction, John. Let me know what you think ...
9 years, 3 months ago (2011-09-09 23:54:42 UTC) #1
jam
lgtm!
9 years, 3 months ago (2011-09-10 00:05:38 UTC) #2
achuithb
Upon further reflection, it dawned on me that we also need to notify our listeners, ...
9 years, 3 months ago (2011-09-10 02:05:48 UTC) #3
jam
lgtm
9 years, 3 months ago (2011-09-12 18:04:29 UTC) #4
achuithb
Thanks John.
9 years, 3 months ago (2011-09-12 18:17:08 UTC) #5
oshima
9 years, 3 months ago (2011-09-14 01:46:10 UTC) #6
After this CL, NotificationTest is having dcheck failure. (crbug.com/96461)
Achuith, could you please look into this? 

thanks,

On 2011/09/12 18:17:08, achuith.bhandarkar wrote:
> Thanks John.

Powered by Google App Engine
This is Rietveld 408576698