Refactor Mac crash key reporting - move to base/mac/crash_logging.{h,mm}

Refactor Mac crash key reporting - move to base/mac/crash_logging.{h,mm}

Breakpad support currently resides in chrome/app/breakpad_mac.* this makes it inaccessible to lower level code that would also like to set crash keys e.g. The sandboxing infrastructure.

This CL refactors the crash key reporting code to reside in base/mac.

Logging is also added to the Sandbox code to try to track down the cause of crbug.com/94758.

BUG=95272, 94758
TEST=On official builds crash logs should contain crash keys e.g. OS version.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=100626

[jeremy, 2011-09-08 09:16:48]

I've verified that crash keys are still uploaded in the official build.

[jeremy, 2011-09-08 09:19:56]

Shess: Can you please review.
Brett: owner rubberstamp OK.

[Scott Hess - ex-Googler, 2011-09-08 19:46:46]

This is great!  LGTM, minor nits to address.

I'm thinking a useful next step would be to tweak the debug build to track these
for inclusion with the signal-backtrace-dump...

http://codereview.chromium.org/7849011/diff/1/base/mac/crash_logging.h
File base/mac/crash_logging.h (right):

http://codereview.chromium.org/7849011/diff/1/base/mac/crash_logging.h#newcode8
base/mac/crash_logging.h:8: #if __OBJC__
I think this stuff was in the breakpad_mac.h because that is included by non-OSX
code.  Users of this file will have to grok NSString, so it could probably be
removed.

http://codereview.chromium.org/7849011/diff/1/chrome/app/breakpad_mac.mm
File chrome/app/breakpad_mac.mm (right):

http://codereview.chromium.org/7849011/diff/1/chrome/app/breakpad_mac.mm#newc...
chrome/app/breakpad_mac.mm:179: ClearCrashKeyValue);
Oh!  I had thought this bug was kinda pedantic, and might not be worth the
bother, I didn't realize we were already halfway there!

http://codereview.chromium.org/7849011/diff/1/chrome/app/breakpad_mac_stubs.mm
File chrome/app/breakpad_mac_stubs.mm (left):

http://codereview.chromium.org/7849011/diff/1/chrome/app/breakpad_mac_stubs.m...
chrome/app/breakpad_mac_stubs.mm:34: // breakpad_mac.mm.
Nice to be able to address this...

http://codereview.chromium.org/7849011/diff/1/chrome/common/child_process_log...
File chrome/common/child_process_logging_mac.mm (right):

http://codereview.chromium.org/7849011/diff/1/chrome/common/child_process_log...
chrome/common/child_process_logging_mac.mm:93: SetActiveURLImpl(url,
SetCrashKeyValue, ClearCrashKey);
Indentation.

[brettw, 2011-09-08 19:50:51]

LGTM rubberstamp

[commit-bot: I haz the power, 2011-09-11 11:29:50]

Change committed as 100626