Refactor Mac crash key reporting - move to base/mac/crash_logging.{h,mm}

chrome/app/breakpad_mac_stubs.mm

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/app/breakpad_mac.h"
 
 #import <Foundation/Foundation.h>
 
 // Stubbed out versions of breakpad integration functions so we can compile
 // without linking in Breakpad.
 
 bool IsCrashReporterEnabled() {
   return false;
 }
 
 void InitCrashProcessInfo() {
 }
 
 void DestructCrashReporter() {
 }
 
 void InitCrashReporter() {
 }
-
-void SetCrashKeyValue(NSString* key, NSString* value) {
-}
-
-void ClearCrashKeyValue(NSString* key) {
-}
-
-// NOTE(shess): These functions could clearly be replaced by stubs,
-// but since they are seldom-used helpers, it seemed more reasonable
-// to duplicate them from the primary implementation in
-// breakpad_mac.mm.

[Scott Hess - ex-Googler, 2011/09/08 19:46:46]

Nice to be able to address this...

-ScopedCrashKey::ScopedCrashKey(NSString* key, NSString* value)
-    : crash_key_([key retain]) {
-  SetCrashKeyValue(crash_key_.get(), value);
-}
-
-ScopedCrashKey::~ScopedCrashKey() {
-  ClearCrashKeyValue(crash_key_.get());
-}