Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Unified Diff: src/d8.h

Issue 7846022: Release memory of semaphores and thread pointers by using 'delete' instead of SmartPointer. (Closed) Base URL: git://github.com/v8/v8.git@master
Patch Set: Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/d8.cc » ('j') | src/d8.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/d8.h
diff --git a/src/d8.h b/src/d8.h
index 3ec03907ed112259cce70fddc1fc8da8140b0d3f..11656e549e697d7e81cbe0ad030a1e9d4ebf8db5 100644
--- a/src/d8.h
+++ b/src/d8.h
@@ -31,7 +31,6 @@
#ifndef V8_SHARED
#include "allocation.h"
#include "hashmap.h"
-#include "smart-pointer.h"
#include "v8.h"
#else
#include "../include/v8.h"
@@ -122,10 +121,12 @@ class SourceGroup {
#ifndef V8_SHARED
next_semaphore_(v8::internal::OS::CreateSemaphore(0)),
done_semaphore_(v8::internal::OS::CreateSemaphore(0)),
+ thread_(NULL),
#endif // V8_SHARED
argv_(NULL),
begin_offset_(0),
end_offset_(0) {}
+ ~SourceGroup();
Vitaly Repeshko 2011/09/08 22:45:05 nit: Insert a blank line.
void Begin(char** argv, int offset) {
argv_ = const_cast<const char**>(argv);
@@ -157,9 +158,9 @@ class SourceGroup {
static i::Thread::Options GetThreadOptions();
void ExecuteInThread();
- i::SmartPointer<i::Semaphore> next_semaphore_;
- i::SmartPointer<i::Semaphore> done_semaphore_;
- i::SmartPointer<i::Thread> thread_;
+ i::Semaphore* next_semaphore_;
+ i::Semaphore* done_semaphore_;
+ i::Thread* thread_;
#endif // V8_SHARED
void ExitShell(int exit_code);
« no previous file with comments | « no previous file | src/d8.cc » ('j') | src/d8.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698