Release memory of semaphores and thread pointers by using 'delete' instead of SmartPointer.

src/d8.h

 // Copyright 2009 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 13 matching lines @@
 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
 #ifndef V8_D8_H_
 #define V8_D8_H_
 
 #ifndef V8_SHARED
 #include "allocation.h"
 #include "hashmap.h"
-#include "smart-pointer.h"
 #include "v8.h"
 #else
 #include "../include/v8.h"
 #endif  // V8_SHARED
 
 namespace v8 {
 
 
 #ifndef V8_SHARED
 // A single counter in a counter collection.
@@ skipping 70 matching lines @@
 };
 #endif  // V8_SHARED
 
 
 class SourceGroup {
  public:
   SourceGroup() :
 #ifndef V8_SHARED
       next_semaphore_(v8::internal::OS::CreateSemaphore(0)),
       done_semaphore_(v8::internal::OS::CreateSemaphore(0)),
+      thread_(NULL),
 #endif  // V8_SHARED
       argv_(NULL),
       begin_offset_(0),
       end_offset_(0) {}
+  ~SourceGroup();

[Vitaly Repeshko, 2011/09/08 22:45:05]

nit: Insert a blank line.

 
   void Begin(char** argv, int offset) {
     argv_ = const_cast<const char**>(argv);
     begin_offset_ = offset;
   }
 
   void End(int offset) { end_offset_ = offset; }
 
   void Execute();
 
@@ skipping 11 matching lines @@
       group_->ExecuteInThread();
     }
 
    private:
     SourceGroup* group_;
   };
 
   static i::Thread::Options GetThreadOptions();
   void ExecuteInThread();
 
-  i::SmartPointer<i::Semaphore> next_semaphore_;
-  i::SmartPointer<i::Semaphore> done_semaphore_;
-  i::SmartPointer<i::Thread> thread_;
+  i::Semaphore* next_semaphore_;
+  i::Semaphore* done_semaphore_;
+  i::Thread* thread_;
 #endif  // V8_SHARED
 
   void ExitShell(int exit_code);
   Handle<String> ReadFile(const char* name);
 
   const char** argv_;
   int begin_offset_;
   int end_offset_;
 };
 
@@ skipping 176 matching lines @@
   LineEditor* next_;
   static LineEditor* first_;
 };
 #endif  // V8_SHARED
 
 
 }  // namespace v8
 
 
 #endif  // V8_D8_H_