Release memory of semaphores and thread pointers by using 'delete' instead of SmartPointer.

Release memory of semaphores and thread pointers by using 'delete' instead of SmartPointer.

As pointed out in: http://codereview.chromium.org/7754007/

SmartPointer expects an input allocated using new[] and deallocates it using delete[].
So using SmartPointer for deleting T* here is incorrect. Fix it now.

R=vitalyr@chromium.org

Committed: http://code.google.com/p/v8/source/detail?r=9205

[Vitaly Repeshko, 2011-09-08 22:45:05]

LGTM. Landed in r9205 (with the nit fixed).

http://codereview.chromium.org/7846022/diff/4/src/d8.h
File src/d8.h (right):

http://codereview.chromium.org/7846022/diff/4/src/d8.h#newcode129
src/d8.h:129: ~SourceGroup();
nit: Insert a blank line.

[Vitaly Repeshko, 2011-09-08 22:56:40]

http://codereview.chromium.org/7846022/diff/4/src/d8.cc
File src/d8.cc (right):

http://codereview.chromium.org/7846022/diff/4/src/d8.cc#newcode1081
src/d8.cc:1081: thread_ = NULL;
Ooops, didn't notice this edit. This looks wrong.

[tfarina, 2011-09-08 22:58:18]

http://codereview.chromium.org/7846022/diff/4/src/d8.cc
File src/d8.cc (right):

http://codereview.chromium.org/7846022/diff/4/src/d8.cc#newcode1081
src/d8.cc:1081: thread_ = NULL;
On 2011/09/08 22:56:40, Vitaly Repeshko wrote:
> Ooops, didn't notice this edit. This looks wrong.

Double-free? It was here before the SmartPointer change.

[tfarina, 2011-09-08 23:04:06]

It broke the shared library compilation. I'm going to fix it.