Issue 7845017: Fix bug in SimulateAttrib0 that did not check for out of memory.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7845017: Fix bug in SimulateAttrib0 that did not check for out of memory. (Closed)

Created:
9 years, 3 months ago by greggman

Modified:
9 years, 3 months ago

Reviewers:
commit-bot: I haz the power, Peter Mayo, apatrick_chromium

CC:
chromium-reviews, apatrick_chromium, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Fix bug in SimulateAttrib0 that did not check for out of memory. It also did not correctly check for math overflow. Also fixed similar bugs in SimulateFixedAttribs TEST=unit tests BUG=95625 R=apatrick@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=100384

Patch Set 1 #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+121 lines, -32 lines)			Patch
	M	gpu/command_buffer/service/gles2_cmd_decoder.cc	View		7 chunks	+49 lines, -14 lines	0 comments	Download
	M	gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc	View		3 chunks	+72 lines, -18 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

The commit queue went berserk retrying too often for a seemingly flaky test. Builder is ...

9 years, 3 months ago (2011-09-09 07:43:22 UTC) #3

Peter Mayo

9 years, 3 months ago (2011-09-09 16:54:53 UTC) #5

On 2011/09/09 10:28:10, I haz the power (commit-bot) wrote:
> Change committed as 100384

This change appears to cause test failures on

Linux, Linux Touch, Mac 10.5 Mac 10.6 & Linux x64

Noticeably, not everywhere.

Please investigate and fix (this looks like it could be a crash fix, so
hopefully not revert)

Expand Messages | Collapse Messages