Issue 7840040: Disable PIE for dump_syms

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7840040: Disable PIE for dump_syms (Closed)

Created:
9 years, 3 months ago by Mark Mentovai

Modified:
9 years, 3 months ago

Reviewers:
TVL

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Disable PIE for dump_syms. The framework is too big to reliably be able to mmap it in a 32-bit process with PIE on. There may not be a big enough gap in the address space to mmap it. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=100149

Patch Set 1 #

Patch Set 2 : '' #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -23 lines)			Patch
	M	breakpad/breakpad.gyp	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download
	M	build/common.gypi	View	1	3 chunks	+27 lines, -23 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

I changed the approach here. It’s much cleaner now because targets like dump_syms don’t need ...

9 years, 3 months ago (2011-09-08 14:36:07 UTC) #3

lgtm

Expand Messages | Collapse Messages