Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5006)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: breakpad/breakpad.gyp

Issue 7840040: Disable PIE for dump_syms (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/common.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: breakpad/breakpad.gyp
===================================================================
--- breakpad/breakpad.gyp (revision 99959)
+++ breakpad/breakpad.gyp (working copy)
@@ -104,6 +104,12 @@
{
'target_name': 'dump_syms',
'type': 'executable',
+ 'variables': {
+ # Turn off PIE because it may interfere with dump_syms' ability to
+ # allocate a contiguous region in memory large enough to mmap the
+ # entire unstripped framework in a 32-bit dump_syms process.
+ 'mac_pie': 0,
+ },
'include_dirs++': [
# ++ ensures this comes before src brought in from target_defaults.
'pending/src',
« no previous file with comments | « no previous file | build/common.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698