Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5286)

Unified Diff: chrome/browser/prefs/pref_value_store.cc

Issue 7838030: WIP: Introduce per-TabContents PrefService. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Use TabContentsWrapper instead of rolling our own TabContents property. Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/prefs/pref_value_store.cc
diff --git a/chrome/browser/prefs/pref_value_store.cc b/chrome/browser/prefs/pref_value_store.cc
index bc759f84802476c5218c21cd14f52f9caffeb8ff..7172ee79d95066a0765746fcc829ef7f21d201c1 100644
--- a/chrome/browser/prefs/pref_value_store.cc
+++ b/chrome/browser/prefs/pref_value_store.cc
@@ -5,7 +5,6 @@
#include "chrome/browser/prefs/pref_value_store.h"
#include "base/logging.h"
-#include "chrome/browser/prefs/pref_model_associator.h"
#include "chrome/browser/prefs/pref_notifier.h"
PrefValueStore::PrefStoreKeeper::PrefStoreKeeper()
@@ -52,10 +51,8 @@ PrefValueStore::PrefValueStore(PrefStore* managed_platform_prefs,
PrefStore* recommended_platform_prefs,
PrefStore* recommended_cloud_prefs,
PrefStore* default_prefs,
- PrefModelAssociator* pref_sync_associator,
PrefNotifier* pref_notifier)
- : pref_sync_associator_(pref_sync_associator),
- pref_notifier_(pref_notifier),
+ : pref_notifier_(pref_notifier),
initialization_failed_(false) {
InitPrefStore(MANAGED_PLATFORM_STORE, managed_platform_prefs);
InitPrefStore(MANAGED_CLOUD_STORE, managed_cloud_prefs);
@@ -80,7 +77,6 @@ PrefValueStore* PrefValueStore::CloneAndSpecialize(
PrefStore* recommended_platform_prefs,
PrefStore* recommended_cloud_prefs,
PrefStore* default_prefs,
- PrefModelAssociator* pref_sync_associator,
PrefNotifier* pref_notifier) {
DCHECK(pref_notifier);
if (!managed_platform_prefs)
@@ -103,8 +99,7 @@ PrefValueStore* PrefValueStore::CloneAndSpecialize(
return new PrefValueStore(
managed_platform_prefs, managed_cloud_prefs, extension_prefs,
command_line_prefs, user_prefs, recommended_platform_prefs,
- recommended_cloud_prefs, default_prefs, pref_sync_associator,
- pref_notifier);
+ recommended_cloud_prefs, default_prefs, pref_notifier);
}
bool PrefValueStore::GetValue(const std::string& name,
@@ -136,11 +131,8 @@ void PrefValueStore::NotifyPrefChanged(
// If the pref is controlled by a higher-priority store, its effective value
// cannot have changed.
PrefStoreType controller = ControllingPrefStoreForPref(path);
- if (controller == INVALID_STORE || controller >= new_store) {
+ if (controller == INVALID_STORE || controller >= new_store)
pref_notifier_->OnPreferenceChanged(path);
- if (pref_sync_associator_)
- pref_sync_associator_->ProcessPrefChange(path);
- }
}
bool PrefValueStore::PrefValueInManagedStore(const char* name) const {

Powered by Google App Engine
This is Rietveld 408576698