Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6595)

Unified Diff: chrome/browser/ui/tab_contents/tab_contents_wrapper.h

Issue 7838030: WIP: Introduce per-TabContents PrefService. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Use TabContentsWrapper instead of rolling our own TabContents property. Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/tab_contents/tab_contents_wrapper.h
diff --git a/chrome/browser/ui/tab_contents/tab_contents_wrapper.h b/chrome/browser/ui/tab_contents/tab_contents_wrapper.h
index 019c0b74d71ba8284bfdffa4594b95a60e2ef42b..5e876e5a11c28e765fa60199432d156f25c7db32 100644
--- a/chrome/browser/ui/tab_contents/tab_contents_wrapper.h
+++ b/chrome/browser/ui/tab_contents/tab_contents_wrapper.h
@@ -32,13 +32,14 @@ class FaviconTabHelper;
class FileSelectObserver;
class FindTabHelper;
class FirewallTraversalObserver;
-class InfoBarTabHelper;
class HistoryTabHelper;
+class InfoBarTabHelper;
class NavigationController;
class OmniboxSearchHint;
class PasswordManager;
class PasswordManagerDelegate;
class PluginObserver;
+class PrefService;
class Profile;
class RestoreTabHelper;
class SearchEngineTabHelper;
@@ -63,8 +64,8 @@ class PrerenderTabHelper;
}
namespace printing {
-class PrintViewManager;
class PrintPreviewMessageHandler;
+class PrintViewManager;
}
namespace safe_browsing {
@@ -210,6 +211,10 @@ class TabContentsWrapper : public TabContentsObserver,
return web_intent_picker_controller_.get();
}
+ PrefService* per_tab_prefs() {
Avi (use Gerrit) 2011/09/08 14:33:37 When you notice a pattern of alphabetical items, p
+ return per_tab_prefs_.get();
+ }
+
// Overrides -----------------------------------------------------------------
// TabContentsObserver overrides:
@@ -308,6 +313,8 @@ class TabContentsWrapper : public TabContentsObserver,
scoped_ptr<TranslateTabHelper> translate_tab_helper_;
+ scoped_ptr<PrefService> per_tab_prefs_;
Avi (use Gerrit) 2011/09/08 14:33:37 ditto re alphabetizing
+
// Per-tab observers ---------------------------------------------------------
// (These provide no API for callers; objects that need to exist 1:1 with tabs
// and silently do their thing live here.)

Powered by Google App Engine
This is Rietveld 408576698