Issue 7838018: Fix crash or hang on Windows when clicking on wrench icon in panel opened from non-extension domain.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7838018: Fix crash or hang on Windows when clicking on wrench icon in panel opened from non-extension domain. (Closed)

Created:
9 years, 3 months ago by jianli

Modified:
9 years, 3 months ago

Reviewers:
jennb

CC:
chromium-reviews, jennb, jianli, Dmitry Titov, dcheng, prasadt

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fix crash or hang on Windows when clicking on wrench icon in panel opened from non-extension domain. BUG=none TEST=Manual test by opening a panel from non-extension and clicking on wrench button Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=99971

Patch Set 1 #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -5 lines)			Patch
	M	chrome/browser/ui/panels/panel_browser_frame_view.h	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	chrome/browser/ui/panels/panel_browser_frame_view.cc	View		3 chunks	+6 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

jennb

9 years, 3 months ago (2011-09-07 17:17:34 UTC) #2

LGTM

The TEST= line needs to include more info on how to manually test the fix.

Expand Messages | Collapse Messages