Fix crash or hang on Windows when clicking on wrench icon in panel opened from non-extension domain.

chrome/browser/ui/panels/panel_browser_frame_view.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/panels/panel_browser_frame_view.h"
 
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/themes/theme_service.h"
 #include "chrome/browser/ui/panels/panel.h"
@@ skipping 420 matching lines @@
   BrowserNonClientFrameView::OnMouseCaptureLost();
 }
 
 void PanelBrowserFrameView::ButtonPressed(views::Button* sender,
                                           const views::Event& event) {
   if (sender == close_button_)
     frame_->Close();
 }
 
 void PanelBrowserFrameView::RunMenu(View* source, const gfx::Point& pt) {
-  EnsureSettingsMenuCreated();
+  if (!EnsureSettingsMenuCreated())
+    return;
 
   DCHECK_EQ(settings_button_, source);
   gfx::Point screen_point;
   views::View::ConvertPointToScreen(source, &screen_point);
   if (settings_menu_runner_.RunMenuAt(source->GetWidget(),
           settings_button_, gfx::Rect(screen_point, source->size()),
           views::MenuItemView::TOPRIGHT, views::MenuRunner::HAS_MNEMONICS) ==
       views::MenuRunner::MENU_DELETED)
     return;
 }
@@ skipping 278 matching lines @@
 void PanelBrowserFrameView::UpdateSettingsButtonVisibility(
     bool focused, bool cursor_in_view) {
   is_settings_button_visible_ = focused || cursor_in_view;
   settings_button_->SetVisible(is_settings_button_visible_);
 }
 
 const Extension* PanelBrowserFrameView::GetExtension() const {
   return Panel::GetExtension(browser_view_->browser());
 }
 
-void PanelBrowserFrameView::EnsureSettingsMenuCreated() {
+bool PanelBrowserFrameView::EnsureSettingsMenuCreated() {
   if (settings_menu_contents_.GetItemCount())
-    return;
+    return true;
 
   const Extension* extension = GetExtension();
   if (!extension)
-    return;
+    return false;
 
   settings_menu_contents_.AddItem(
       COMMAND_NAME, UTF8ToUTF16(extension->name()));
   settings_menu_contents_.AddSeparator();
   settings_menu_contents_.AddItem(
       COMMAND_CONFIGURE, l10n_util::GetStringUTF16(IDS_EXTENSIONS_OPTIONS));
   settings_menu_contents_.AddItem(
       COMMAND_DISABLE, l10n_util::GetStringUTF16(IDS_EXTENSIONS_DISABLE));
   settings_menu_contents_.AddItem(
       COMMAND_UNINSTALL, l10n_util::GetStringUTF16(IDS_EXTENSIONS_UNINSTALL));
   settings_menu_contents_.AddSeparator();
   settings_menu_contents_.AddItem(
       COMMAND_MANAGE, l10n_util::GetStringUTF16(IDS_MANAGE_EXTENSIONS));
 
   settings_menu_adapter_.BuildMenu(settings_menu_);
+  return true;
 }