Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1237)

Unified Diff: net/url_request/url_request_http_job.cc

Issue 7833042: Finalize a CL originally by departed intern ycxiao@ that detaches the loading of cookies from the... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/url_request/url_request_http_job.h ('k') | net/url_request/url_request_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/url_request/url_request_http_job.cc
===================================================================
--- net/url_request/url_request_http_job.cc (revision 99705)
+++ net/url_request/url_request_http_job.cc (working copy)
@@ -543,14 +543,14 @@
}
void URLRequestHttpJob::OnCookiesLoaded(
- std::string* cookie_line,
- std::vector<net::CookieStore::CookieInfo>* cookie_infos) {
- if (!cookie_line->empty()) {
+ const std::string& cookie_line,
+ const std::vector<net::CookieStore::CookieInfo>& cookie_infos) {
+ if (!cookie_line.empty()) {
request_info_.extra_headers.SetHeader(
- HttpRequestHeaders::kCookie, *cookie_line);
+ HttpRequestHeaders::kCookie, cookie_line);
}
if (URLRequest::AreMacCookiesEnabled())
- AddAuthorizationHeader(*cookie_infos, &request_info_);
+ AddAuthorizationHeader(cookie_infos, &request_info_);
DoStartTransaction();
}
« no previous file with comments | « net/url_request/url_request_http_job.h ('k') | net/url_request/url_request_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698