Finalize a CL originally by departed intern ycxiao@ that detaches the loading of cookies from the...

net/url_request/url_request_http_job.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/url_request/url_request_http_job.h"
 
 #include "base/bind.h"
 #include "base/base_switches.h"
 #include "base/command_line.h"
 #include "base/compiler_specific.h"
@@ skipping 525 matching lines @@
     request_->context()->cookie_store()->GetCookiesWithInfoAsync(
         request_->url(), options,
         base::Bind(&URLRequestHttpJob::OnCookiesLoaded,
                    weak_ptr_factory_.GetWeakPtr()));
   } else {
     DoStartTransaction();
   }
 }
 
 void URLRequestHttpJob::OnCookiesLoaded(
-    std::string* cookie_line,
-    std::vector<net::CookieStore::CookieInfo>* cookie_infos) {
-  if (!cookie_line->empty()) {
+    const std::string& cookie_line,
+    const std::vector<net::CookieStore::CookieInfo>& cookie_infos) {
+  if (!cookie_line.empty()) {
     request_info_.extra_headers.SetHeader(
-        HttpRequestHeaders::kCookie, *cookie_line);
+        HttpRequestHeaders::kCookie, cookie_line);
   }
   if (URLRequest::AreMacCookiesEnabled())
-    AddAuthorizationHeader(*cookie_infos, &request_info_);
+    AddAuthorizationHeader(cookie_infos, &request_info_);
   DoStartTransaction();
 }
 
 void URLRequestHttpJob::DoStartTransaction() {
   // We may have been canceled while retrieving cookies.
   if (GetStatus().is_success()) {
     StartTransaction();
   } else {
     NotifyCanceled();
   }
@@ skipping 911 matching lines @@
   if (done_)
     return;
   done_ = true;
 
   RecordPerfHistograms(reason);
   if (reason == FINISHED)
     RecordCompressionHistograms();
 }
 
 }  // namespace net