aura: A few changes to have aura_demo compile and run on linux.

aura: A few changes to have aura_demo compile and run on linux.

 * Make 'aura' a component, and export Desktop and Window.
 * Events (Key and Mouse) from X Events.
 * Rip non-gtk bits out of gfx/gtk_util into gfx/linux_util

BUG=93934, 93933
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=99898

[sadrul, 2011-09-03 20:02:25]

This allows aura_demo to be compiled and run on linux (I cannot verify yet that
it paints correctly, since I don't have the right GLX version over NX).

[sky, 2011-09-04 16:01:48]

http://codereview.chromium.org/7833016/diff/3045/aura/desktop_host_linux.cc
File aura/desktop_host_linux.cc (right):

http://codereview.chromium.org/7833016/diff/3045/aura/desktop_host_linux.cc#n...
aura/desktop_host_linux.cc:83: }
break

http://codereview.chromium.org/7833016/diff/3045/aura/desktop_host_linux.cc#n...
aura/desktop_host_linux.cc:89: }
break

http://codereview.chromium.org/7833016/diff/3045/views/views.gyp
File views/views.gyp (left):

http://codereview.chromium.org/7833016/diff/3045/views/views.gyp#oldcode39
views/views.gyp:39: '../net/net.gyp:net',
looks like drop_target_gtk uses one file from net.

[Ben Goodger (Google), 2011-09-04 16:35:45]

http://codereview.chromium.org/7833016/diff/3045/aura/event.h
File aura/event.h (right):

http://codereview.chromium.org/7833016/diff/3045/aura/event.h#newcode16
aura/event.h:16: typedef MSG NativeEvent;
I think these should stay within the aura namespace. We also define NativeEvent
in views.

[sadrul, 2011-09-04 18:14:13]

http://codereview.chromium.org/7833016/diff/3045/aura/desktop_host_linux.cc
File aura/desktop_host_linux.cc (right):

http://codereview.chromium.org/7833016/diff/3045/aura/desktop_host_linux.cc#n...
aura/desktop_host_linux.cc:83: }
On 2011/09/04 16:01:48, sky wrote:
> break

Doh! Done

http://codereview.chromium.org/7833016/diff/3045/aura/desktop_host_linux.cc#n...
aura/desktop_host_linux.cc:89: }
On 2011/09/04 16:01:48, sky wrote:
> break

Done.

http://codereview.chromium.org/7833016/diff/3045/aura/event.h
File aura/event.h (right):

http://codereview.chromium.org/7833016/diff/3045/aura/event.h#newcode16
aura/event.h:16: typedef MSG NativeEvent;
On 2011/09/04 16:35:45, Ben Goodger (Google) wrote:
> I think these should stay within the aura namespace. We also define
NativeEvent
> in views.

Ah yes. Undid the change (had to move the typedef for XEvent out of the
namespace)

http://codereview.chromium.org/7833016/diff/3045/views/views.gyp
File views/views.gyp (left):

http://codereview.chromium.org/7833016/diff/3045/views/views.gyp#oldcode39
views/views.gyp:39: '../net/net.gyp:net',
On 2011/09/04 16:01:48, sky wrote:
> looks like drop_target_gtk uses one file from net.

Indeed. I was trying to get rid of net dependency from views so views can be
built without having to build v8. This change sneaked in from there.

[Ben Goodger (Google), 2011-09-04 21:23:34]

LGTM - thanks for doing this!

[sky, 2011-09-06 14:55:39]

http://codereview.chromium.org/7833016/diff/3045/views/views.gyp
File views/views.gyp (left):

http://codereview.chromium.org/7833016/diff/3045/views/views.gyp#oldcode39
views/views.gyp:39: '../net/net.gyp:net',
On 2011/09/04 18:14:13, sadrul wrote:
> On 2011/09/04 16:01:48, sky wrote:
> > looks like drop_target_gtk uses one file from net.
> 
> Indeed. I was trying to get rid of net dependency from views so views can be
> built without having to build v8. This change sneaked in from there.

We could probably create a ViewsDelegate method for this so that we could remove
the dependency.

[sadrul, 2011-09-06 15:36:59]

On 2011/09/06 14:55:39, sky wrote:
> http://codereview.chromium.org/7833016/diff/3045/views/views.gyp
> File views/views.gyp (left):
> 
> http://codereview.chromium.org/7833016/diff/3045/views/views.gyp#oldcode39
> views/views.gyp:39: '../net/net.gyp:net',
> On 2011/09/04 18:14:13, sadrul wrote:
> > On 2011/09/04 16:01:48, sky wrote:
> > > looks like drop_target_gtk uses one file from net.
> > 
> > Indeed. I was trying to get rid of net dependency from views so views can be
> > built without having to build v8. This change sneaked in from there.
> 
> We could probably create a ViewsDelegate method for this so that we could
remove
> the dependency.

Looks like ui:: also depends on net::, so removing the dependency from views
alone won't be that useful. My current plan is to split net into net_utils and
net, so that ui and views can depend on a light-weight net_utils.

[Ben Goodger (Google), 2011-09-06 15:44:25]

SGTM

On Tue, Sep 6, 2011 at 8:36 AM, <sadrul@chromium.org> wrote:

> On 2011/09/06 14:55:39, sky wrote:
>
>>
http://codereview.chromium.**org/7833016/diff/3045/views/**views.gyp<http://c...
>> File views/views.gyp (left):
>>
>
>  http://codereview.chromium.**org/7833016/diff/3045/views/**
>>
views.gyp#oldcode39<http://codereview.chromium.org/7833016/diff/3045/views/views.gyp#oldcode39>
>> views/views.gyp:39: '../net/net.gyp:net',
>> On 2011/09/04 18:14:13, sadrul wrote:
>> > On 2011/09/04 16:01:48, sky wrote:
>> > > looks like drop_target_gtk uses one file from net.
>> >
>> > Indeed. I was trying to get rid of net dependency from views so views
>> can be
>> > built without having to build v8. This change sneaked in from there.
>>
>
>  We could probably create a ViewsDelegate method for this so that we could
>>
> remove
>
>> the dependency.
>>
>
> Looks like ui:: also depends on net::, so removing the dependency from
> views
> alone won't be that useful. My current plan is to split net into net_utils
> and
> net, so that ui and views can depend on a light-weight net_utils.
>
>
>
http://codereview.chromium.**org/7833016/<http://codereview.chromium.org/7833...
>

[sadrul, 2011-09-06 22:20:57]

Just to clarify: I plan to do that in a separate CL (and land this later
tonight).

On 2011/09/06 15:44:25, Ben Goodger (Google) wrote:
> SGTM
> 
> On Tue, Sep 6, 2011 at 8:36 AM, <mailto:sadrul@chromium.org> wrote:
> 
> > On 2011/09/06 14:55:39, sky wrote:
> >
> >>
>
http://codereview.chromium.**org/7833016/diff/3045/views/**views.gyp%3Chttp:/...>
> >> File views/views.gyp (left):
> >>
> >
> >  http://codereview.chromium.**org/7833016/diff/3045/views/**
> >>
>
views.gyp#oldcode39<http://codereview.chromium.org/7833016/diff/3045/views/views.gyp#oldcode39>
> >> views/views.gyp:39: '../net/net.gyp:net',
> >> On 2011/09/04 18:14:13, sadrul wrote:
> >> > On 2011/09/04 16:01:48, sky wrote:
> >> > > looks like drop_target_gtk uses one file from net.
> >> >
> >> > Indeed. I was trying to get rid of net dependency from views so views
> >> can be
> >> > built without having to build v8. This change sneaked in from there.
> >>
> >
> >  We could probably create a ViewsDelegate method for this so that we could
> >>
> > remove
> >
> >> the dependency.
> >>
> >
> > Looks like ui:: also depends on net::, so removing the dependency from
> > views
> > alone won't be that useful. My current plan is to split net into net_utils
> > and
> > net, so that ui and views can depend on a light-weight net_utils.
> >
> >
> >
>
http://codereview.chromium.**org/7833016/%3Chttp://codereview.chromium.org/78...>
> >

[Ben Goodger (Google), 2011-09-06 22:31:49]

OK

On Tue, Sep 6, 2011 at 3:20 PM, <sadrul@chromium.org> wrote:

> Just to clarify: I plan to do that in a separate CL (and land this later
> tonight).
>
>
> On 2011/09/06 15:44:25, Ben Goodger (Google) wrote:
>
>> SGTM
>>
>
>  On Tue, Sep 6, 2011 at 8:36 AM, <mailto:sadrul@chromium.org> wrote:
>>
>
>  > On 2011/09/06 14:55:39, sky wrote:
>> >
>> >>
>>
>
> http://codereview.chromium.****org/7833016/diff/3045/views/****
> views.gyp%3Chttp://codereview.**chromium.org/7833016/diff/**
>
3045/views/views.gyp<http://codereview.chromium.org/7833016/diff/3045/views/views.gyp>
> >
>
>  >> File views/views.gyp (left):
>> >>
>> >
>> >  http://codereview.chromium.****org/7833016/diff/3045/views/**
>> >>
>>
>
> views.gyp#oldcode39<http://**codereview.chromium.org/**
>
7833016/diff/3045/views/views.**gyp#oldcode39<http://codereview.chromium.org/7833016/diff/3045/views/views.gyp#oldcode39>
> >
>
>  >> views/views.gyp:39: '../net/net.gyp:net',
>> >> On 2011/09/04 18:14:13, sadrul wrote:
>> >> > On 2011/09/04 16:01:48, sky wrote:
>> >> > > looks like drop_target_gtk uses one file from net.
>> >> >
>> >> > Indeed. I was trying to get rid of net dependency from views so views
>> >> can be
>> >> > built without having to build v8. This change sneaked in from there.
>> >>
>> >
>> >  We could probably create a ViewsDelegate method for this so that we
>> could
>> >>
>> > remove
>> >
>> >> the dependency.
>> >>
>> >
>> > Looks like ui:: also depends on net::, so removing the dependency from
>> > views
>> > alone won't be that useful. My current plan is to split net into
>> net_utils
>> > and
>> > net, so that ui and views can depend on a light-weight net_utils.
>> >
>> >
>> >
>>
>
> http://codereview.chromium.****org/7833016/%3Chttp://coderevi**
> ew.chromium.org/7833016/ <http://codereview.chromium.org/7833016/>>
>
>  >
>>
>
>
>
>
http://codereview.chromium.**org/7833016/<http://codereview.chromium.org/7833...
>