[Sync UI] Show only one sync status on personal options page.

[Sync UI] Show only one sync status on personal options page.
Prior to this fix, the sync status would briefly display
"Synced to ...@gmail.com. Last synced: Just now".

BUG=84907
TEST=Go to chrome://settings/personal. Sign into sync. Click the "Enable Autofill..." checkbox. The sync status line should not change -- should still be "Last synced to ... Manage data on Google Dashboard".


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=101257

[binji, 2011-09-01 21:12:03]

The function GetSyncedStateStatusLabel is only used by GetStatusInfo, which is
only used by GetStatus, GetStatusLabels, and GetStatusLabelsForNewTabPage.

GetStatusLabels is only used by the personal options handler (which is the case
we want to fix), and GetStatusLabelsForNewTabPage is only used by the NTP sync
promo, which isn't used in NTP4.

See
http://codesearch.google.com/codesearch#search/&type=cs&q=GetStatusLabels&exa...

[akalin, 2011-09-02 21:50:30]

LGTM

One question: have we decided not to show the last synced time anymore?

[binji, 2011-09-07 17:19:41]

On 2011/09/02 21:50:30, akalin wrote:
> LGTM
> 
> One question: have we decided not to show the last synced time anymore?

tmccoy's response: "Correct. Doesn't mesh well with the idea of always being in
sync, and too much confusion with users thinking they're out of sync when they
haven't made any synced changes in a while."

[binji, 2011-09-14 01:47:46]

ping

[James Hawkins, 2011-09-14 01:50:22]

LGTM

[commit-bot: I haz the power, 2011-09-14 21:31:15]

Can't apply patch for file
chrome/browser/ui/webui/options/personal_options_handler.cc.
While running patch -p1 --forward --force;
patching file chrome/browser/ui/webui/options/personal_options_handler.cc
Hunk #1 succeeded at 239 (offset -2 lines).
Hunk #2 FAILED at 416.
1 out of 2 hunks FAILED -- saving rejects to file
chrome/browser/ui/webui/options/personal_options_handler.cc.rej

[commit-bot: I haz the power, 2011-09-15 06:43:07]

Change committed as 101257