Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 7828024: Do not run integration tests on upload, they are too slow. (Closed)

Created:
9 years, 3 months ago by M-A Ruel
Modified:
9 years, 3 months ago
CC:
chromium-reviews, Dirk Pranke
Visibility:
Public.

Description

Do not run integration tests on upload, they are too slow. gclient_scm_test.py throws randomly gclient_utils.Error. Simply update the test expectation. It has no effect on runtime. BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=99436

Patch Set 1 #

Patch Set 2 : Presubmit checks took 19.6s to calculate. #

Patch Set 3 : typo #

Total comments: 1

Patch Set 4 : . #

Patch Set 5 : Fix support for git 1.7.0 #

Patch Set 6 : git branch has no -q flag #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -7 lines) Patch
M PRESUBMIT.py View 1 2 3 3 chunks +12 lines, -5 lines 0 comments Download
M tests/gclient_scm_test.py View 1 chunk +1 line, -1 line 0 comments Download
M tests/upstream.sh View 1 2 3 4 5 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
M-A Ruel
9 years, 3 months ago (2011-09-01 20:31:51 UTC) #1
Dirk Pranke
LGTM. http://codereview.chromium.org/7828024/diff/1003/PRESUBMIT.py File PRESUBMIT.py (right): http://codereview.chromium.org/7828024/diff/1003/PRESUBMIT.py#newcode12 PRESUBMIT.py:12: def CommonChecks(input_api, output_api, integration_tests): I'd probably just call ...
9 years, 3 months ago (2011-09-01 20:38:00 UTC) #2
commit-bot: I haz the power
Presubmit check for 7828024-4001 failed and returned exit status 1. Running presubmit commit checks ...
9 years, 3 months ago (2011-09-02 01:31:06 UTC) #3
M-A Ruel
On 2011/09/02 01:31:06, I haz the power (commit-bot) wrote: > Presubmit check for 7828024-4001 failed ...
9 years, 3 months ago (2011-09-02 01:41:09 UTC) #4
M-A Ruel
Added work around lack of git checkout -B support. Testing the change.
9 years, 3 months ago (2011-09-02 20:05:37 UTC) #5
commit-bot: I haz the power
Presubmit check for 7828024-6001 failed and returned exit status 1. Running presubmit commit checks ...
9 years, 3 months ago (2011-09-02 20:08:06 UTC) #6
commit-bot: I haz the power
Change committed as 99436
9 years, 3 months ago (2011-09-02 20:13:20 UTC) #7
M-A Ruel
9 years, 3 months ago (2011-09-02 20:13:33 UTC) #8
On 2011/09/02 20:13:20, I haz the power (commit-bot) wrote:
> Change committed as 99436

OMFG.

Powered by Google App Engine
This is Rietveld 408576698