Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Unified Diff: PRESUBMIT.py

Issue 7828024: Do not run integration tests on upload, they are too slow. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools
Patch Set: git branch has no -q flag Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/gclient_scm_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: PRESUBMIT.py
diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index 7d86fde7953bffed55837bcfa3d11131ba085451..cfa82a5f51314bb233a0d0c40c1f980a7c10898d 100644
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -9,7 +9,7 @@ details on the presubmit API built into depot_tools.
"""
-def CommonChecks(input_api, output_api):
+def CommonChecks(input_api, output_api, tests_to_black_list):
results = []
import sys
if not sys.version.startswith('2.5'):
@@ -41,8 +41,8 @@ def CommonChecks(input_api, output_api):
input_api,
output_api,
'tests',
- whitelist=[r'.*test\.py$']))
- results.extend(RunGitClTests(input_api, output_api))
+ whitelist=[r'.*tests\.py$'],
+ blacklist=tests_to_black_list))
return results
@@ -95,13 +95,20 @@ def RunGitClTests(input_api, output_api):
def CheckChangeOnUpload(input_api, output_api):
- return CommonChecks(input_api, output_api)
+ # Do not run integration tests on upload since they are way too slow.
+ tests_to_black_list = [
+ r'^checkout_test\.py$',
+ r'^gclient_smoketest\.py$',
+ r'^scm_unittest\.py$',
+ ]
+ return CommonChecks(input_api, output_api, tests_to_black_list)
def CheckChangeOnCommit(input_api, output_api):
output = []
- output.extend(CommonChecks(input_api, output_api))
+ output.extend(CommonChecks(input_api, output_api, []))
output.extend(input_api.canned_checks.CheckDoNotSubmit(
input_api,
output_api))
+ output.extend(RunGitClTests(input_api, output_api))
return output
« no previous file with comments | « no previous file | tests/gclient_scm_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698