Identify the omnibox as a URL field.

views/controls/textfield/textfield.cc

Index: views/controls/textfield/textfield.cc
diff --git a/views/controls/textfield/textfield.cc b/views/controls/textfield/textfield.cc
index 8061126d257cd0d41f57000510b0c9985f041461..8c77a169208f4b1c670d1f34ab65f56b70eab61d 100644
--- a/views/controls/textfield/textfield.cc
+++ b/views/controls/textfield/textfield.cc
@@ -13,6 +13,7 @@
 #include "base/string_util.h"
 #include "base/utf_string_conversions.h"
 #include "ui/base/accessibility/accessible_view_state.h"
+#include "ui/base/ime/text_input_type.h"
 #include "ui/base/keycodes/keyboard_codes.h"
 #include "ui/base/range/range.h"
 #include "ui/gfx/insets.h"
@@ -53,7 +54,8 @@ Textfield::Textfield()
       use_default_background_color_(true),
       initialized_(false),
       horizontal_margins_were_set_(false),
-      vertical_margins_were_set_(false) {
+      vertical_margins_were_set_(false),
+      text_input_type_(ui::TEXT_INPUT_TYPE_TEXT) {
   set_focusable(true);
 }
 
@@ -70,8 +72,11 @@ Textfield::Textfield(StyleFlags style)
       use_default_background_color_(true),
       initialized_(false),
       horizontal_margins_were_set_(false),
-      vertical_margins_were_set_(false) {
+      vertical_margins_were_set_(false),
+      text_input_type_(ui::TEXT_INPUT_TYPE_TEXT) {
   set_focusable(true);
+  if (IsPassword())
+    SetTextInputType(ui::TEXT_INPUT_TYPE_PASSWORD);
 }
 
 Textfield::~Textfield() {
@@ -99,14 +104,29 @@ bool Textfield::IsPassword() const {
 }
 
 void Textfield::SetPassword(bool password) {
-  if (password)
+  if (password) {
     style_ = static_cast<StyleFlags>(style_ | STYLE_PASSWORD);
-  else
+    SetTextInputType(ui::TEXT_INPUT_TYPE_PASSWORD);
+  } else {
     style_ = static_cast<StyleFlags>(style_ & ~STYLE_PASSWORD);
+    SetTextInputType(ui::TEXT_INPUT_TYPE_TEXT);
+  }

[oshima, 2011/09/02 22:00:10]

I think the only place this is used is in
chrome/browser/chromeos/options/wifi_config_view.cc, which we will replace with
webui. Could you please add TODO to revisit and remove if this is no longer
necessary?

[bryeung, 2011/09/02 23:33:11]

Done.

   if (native_wrapper_)
     native_wrapper_->UpdateIsPassword();
 }
 
+
+ui::TextInputType Textfield::GetTextInputType() const {
+  return text_input_type_;
+}
+
+void Textfield::SetTextInputType(ui::TextInputType type) {
+  text_input_type_ = type;
+  bool should_be_password = type == ui::TEXT_INPUT_TYPE_PASSWORD;

[oshima, 2011/09/02 22:00:10]

This is fine with me, or we can reject TEXT_INPUT_TYPE_PASSWORD to avoid misuse.
I'll leave it to you.

[bryeung, 2011/09/02 23:33:11]

Okay: I'll leave it like this for now and it will get cleaned up when
SetPassword goes away.

+  if (IsPassword() != should_be_password)
+    SetPassword(should_be_password);
+}
+
 void Textfield::SetText(const string16& text) {
   text_ = text;
   if (native_wrapper_)