Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Unified Diff: views/controls/textfield/native_textfield_views.cc

Issue 7826039: Identify the omnibox as a URL field. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: refactor based on comments Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: views/controls/textfield/native_textfield_views.cc
diff --git a/views/controls/textfield/native_textfield_views.cc b/views/controls/textfield/native_textfield_views.cc
index 47ff3029bb754c2d69777a3fce748911e5744f9f..641d6fb48054a05707d7843ffb4339307dfe86b1 100644
--- a/views/controls/textfield/native_textfield_views.cc
+++ b/views/controls/textfield/native_textfield_views.cc
@@ -702,9 +702,7 @@ void NativeTextfieldViews::InsertChar(char16 ch, int flags) {
ui::TextInputType NativeTextfieldViews::GetTextInputType() {
oshima 2011/09/02 22:00:10 looks like we can move this to Textfield?
bryeung 2011/09/02 23:33:11 It's actually an override from TextInputClient (wh
oshima 2011/09/03 00:26:32 I see, then just move the following to Textfield.
if (textfield_->read_only() || !textfield_->IsEnabled())
return ui::TEXT_INPUT_TYPE_NONE;
- else if (textfield_->IsPassword())
- return ui::TEXT_INPUT_TYPE_PASSWORD;
- return ui::TEXT_INPUT_TYPE_TEXT;
+ return textfield_->GetTextInputType();
}
gfx::Rect NativeTextfieldViews::GetCaretBounds() {

Powered by Google App Engine
This is Rietveld 408576698