Issue 7826: Initialize the variable to a valid value.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7826: Initialize the variable to a valid value. (Closed)

Created:
12 years, 2 months ago by Feng Qian

Modified:
9 years, 7 months ago

Reviewers:
iposva

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Initialize the variable to a valid value. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=541

Patch Set 1 #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/factory.cc	View		1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

iposva

12 years, 2 months ago (2008-10-21 20:13:39 UTC) #2

See comment in line. Generally this LGTM, but I really think we should add a
NO_TYPE or INVALID_TYPE to the InstanceType enum.

http://codereview.chromium.org/7826/diff/1/2
File src/factory.cc (right):

http://codereview.chromium.org/7826/diff/1/2#newcode686
Line 686: InstanceType type = JS_OBJECT_TYPE;  // initialize to a valid value
I would prefer to see a NO_TYPE in the InstanceType enum to be able to clearly
indicate that this variable initialization is expected to be overridden. I
understand that there currently is no such invalid InstanceType.

Expand Messages | Collapse Messages