Initialize the variable to a valid value.

src/factory.cc

 // Copyright 2006-2008 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 665 matching lines @@
   int internal_field_count = 0;
   if (!obj->instance_template()->IsUndefined()) {
     Handle<ObjectTemplateInfo> instance_template =
         Handle<ObjectTemplateInfo>(
             ObjectTemplateInfo::cast(obj->instance_template()));
     internal_field_count =
         Smi::cast(instance_template->internal_field_count())->value();
   }
 
   int instance_size = kPointerSize * internal_field_count;
-  InstanceType type;
+  InstanceType type = JS_OBJECT_TYPE;  // initialize to a valid value

[iposva, 2008/10/21 20:13:39]

I would prefer to see a NO_TYPE in the InstanceType enum to be able to clearly
indicate that this variable initialization is expected to be overridden. I
understand that there currently is no such invalid InstanceType.

   switch (instance_type) {
     case JavaScriptObject:
       type = JS_OBJECT_TYPE;
       instance_size += JSObject::kHeaderSize;
       break;
     case InnerGlobalObject:
       type = JS_GLOBAL_OBJECT_TYPE;
       instance_size += JSGlobalObject::kSize;
       break;
     case OuterGlobalObject:
@@ skipping 119 matching lines @@
     Execution::ConfigureInstance(instance,
                                  instance_template,
                                  pending_exception);
   } else {
     *pending_exception = false;
   }
 }
 
 
 } }  // namespace v8::internal