clang style plugin: Don't try to figure out src root.

tools/clang/plugins/ChromeClassTester.cpp

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // A general interface for filtering and only acting on classes in Chromium C++
 // code.
 
 #include "ChromeClassTester.h"
 
 #include <sys/param.h>
@@ skipping 13 matching lines @@
     return false;
 
   return one.compare(one.size() - two.size(), two.size(), two) == 0;
 }
 
 }  // namespace
 
 ChromeClassTester::ChromeClassTester(CompilerInstance& instance)
     : instance_(instance),
       diagnostic_(instance.getDiagnostics()) {
-  FigureOutSrcRoot();
   BuildBannedLists();
 }
 
-void ChromeClassTester::FigureOutSrcRoot() {
-  char c_cwd[MAXPATHLEN];
-  if (getcwd(c_cwd, MAXPATHLEN) > 0) {
-    size_t pos = 1;
-    std::string cwd = c_cwd;
-
-    // Add a trailing '/' because the search below requires it.
-    if (cwd[cwd.size() - 1] != '/')
-      cwd += '/';
-
-    // Search the directory tree downwards until we find a path that contains
-    // "build/common.gypi" and assume that that is our srcroot.
-    size_t next_slash = cwd.find('/', pos);
-    while (next_slash != std::string::npos) {
-      next_slash++;
-      std::string candidate = cwd.substr(0, next_slash);
-
-      if (ends_with(candidate, "src/")) {
-        std::string common = candidate + "build/common.gypi";
-        if (access(common.c_str(), F_OK) != -1) {
-          src_root_ = candidate;
-          break;
-        }
-      }
-
-      pos = next_slash;
-      next_slash = cwd.find('/', pos);
-    }
-  }
-
-  if (src_root_.empty()) {
-    unsigned id = diagnostic().getCustomDiagID(
-        Diagnostic::Error,
-        "WARNING: Can't figure out srcroot!\n");
-    diagnostic().Report(id);
-  }
-}
-
 void ChromeClassTester::BuildBannedLists() {
   banned_namespaces_.push_back("std");
   banned_namespaces_.push_back("__gnu_cxx");
 
-  banned_directories_.push_back("third_party");
-  banned_directories_.push_back("native_client");
-  banned_directories_.push_back("breakpad");
-  banned_directories_.push_back("courgette");
-  banned_directories_.push_back("ppapi");
-  banned_directories_.push_back("testing");
-  banned_directories_.push_back("googleurl");
-  banned_directories_.push_back("v8");
-  banned_directories_.push_back("sdch");
+  banned_directories_.push_back("third_party/");
+  banned_directories_.push_back("native_client/");
+  banned_directories_.push_back("breakpad/");
+  banned_directories_.push_back("courgette/");
+  banned_directories_.push_back("ppapi/");
+  banned_directories_.push_back("usr/");

[hans, 2012/01/16 11:14:22]

It's not uncommon to have Chromium checked out in
/usr/local/something/something. This, combined with matching against the full
path, seems to make the style checker ignore everything?

+  banned_directories_.push_back("testing/");
+  banned_directories_.push_back("googleurl/");
+  banned_directories_.push_back("v8/");
+  banned_directories_.push_back("sdch/");
 
   // Don't check autogenerated headers.
-  banned_directories_.push_back("out");
-  banned_directories_.push_back("llvm");
-  banned_directories_.push_back("ninja");
-  banned_directories_.push_back("xcodebuild");
-  banned_directories_.push_back("clang");
+  banned_directories_.push_back("out/");
+  banned_directories_.push_back("llvm/");
+  banned_directories_.push_back("ninja/");
+  banned_directories_.push_back("xcodebuild/");
+  banned_directories_.push_back("clang/");
 
   // You are standing in a mazy of twisty dependencies, all resolved by
   // putting everything in the header.
-  banned_directories_.push_back("chrome/test/automation");
+  banned_directories_.push_back("automation/");
 
   // Don't check system headers.
-  banned_directories_.push_back("/usr");
-  banned_directories_.push_back("/Developer");
+  banned_directories_.push_back("/Developer/");
 
   // Used in really low level threading code that probably shouldn't be out of
   // lined.
   ignored_record_names_.insert("ThreadLocalBoolean");
 
   // A complicated pickle derived struct that is all packed integers.
   ignored_record_names_.insert("Header");
 
   // Part of the GPU system that uses multiple included header
   // weirdness. Never getting this right.
@@ skipping 144 matching lines @@
     if (ends_with(b, ".pb.h")) {
       return true;
     }
 
     // We need to munge the paths so that they are relative to the repository
     // srcroot. We first resolve the symlinktastic relative path and then
     // remove our known srcroot from it if needed.
     char resolvedPath[MAXPATHLEN];
     if (realpath(b.c_str(), resolvedPath)) {
       std::string resolved = resolvedPath;
-      if (starts_with(resolved, src_root_)) {
-        b = resolved.substr(src_root_.size());
-      }
     }
 
     for (std::vector<std::string>::const_iterator it =
              banned_directories_.begin();
          it != banned_directories_.end(); ++it) {
-      if (starts_with(b, *it)) {
+      // If we can find any of the banned path components in this path, then
+      // this file is rejected.
+      if (b.find(*it) != std::string::npos)
         return true;
-      }
     }
   }
 
   return false;
 }
 
 bool ChromeClassTester::IsIgnoredType(const std::string& base_name) {
   return ignored_record_names_.find(base_name) != ignored_record_names_.end();
 }