Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Issue 7820005: Clean up old dead code. (Closed)

Created:
9 years, 3 months ago by ericu
Modified:
9 years, 3 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, kinuko+watch, jam, pam+watch_chromium.org
Visibility:
Public.

Description

Clean up old dead code. This is the remains of http://codereview.chromium.org/6904063/, a 4-part commit that stalled with full functionality but before full cleanup because I went on leave. Reviewers: Tony for webkit/tools/test_shell ownership, Michael for everything else. BUG=none TEST=existing filesystem tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=99800

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -270 lines) Patch
M content/common/file_system/webfilesystem_callback_dispatcher.cc View 2 chunks +0 lines, -7 lines 0 comments Download
M content/common/file_system/webfilesystem_impl.h View 2 chunks +13 lines, -70 lines 0 comments Download
M content/common/file_system/webfilesystem_impl.cc View 1 chunk +0 lines, -61 lines 0 comments Download
M webkit/fileapi/file_system_util.cc View 1 chunk +1 line, -17 lines 0 comments Download
M webkit/tools/test_shell/simple_file_system.h View 1 chunk +12 lines, -50 lines 0 comments Download
M webkit/tools/test_shell/simple_file_system.cc View 2 chunks +0 lines, -65 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
ericu
This should be an easy one.
9 years, 3 months ago (2011-08-31 21:27:20 UTC) #1
ericu
+tony, OWNER of test_shell.
9 years, 3 months ago (2011-08-31 21:28:04 UTC) #2
michaeln
lgtm, nice to see deleted stuff :)
9 years, 3 months ago (2011-08-31 21:28:23 UTC) #3
tony
test_shell LGTM
9 years, 3 months ago (2011-08-31 21:30:05 UTC) #4
commit-bot: I haz the power
Try job failure for 7820005-1 on win for steps "update_scripts, update". http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number=52408 Step "update" is ...
9 years, 3 months ago (2011-09-01 02:04:28 UTC) #5
commit-bot: I haz the power
Try job failure for 7820005-1 (retry) on mac for step "compile" (clobber build). It's a ...
9 years, 3 months ago (2011-09-01 17:50:10 UTC) #6
commit-bot: I haz the power
9 years, 3 months ago (2011-09-06 20:28:08 UTC) #7
Change committed as 99800

Powered by Google App Engine
This is Rietveld 408576698