extensions: Use Version ctor instead of calling GetVersionFromString().

chrome/browser/extensions/extension_updater.cc

Index: chrome/browser/extensions/extension_updater.cc
diff --git a/chrome/browser/extensions/extension_updater.cc b/chrome/browser/extensions/extension_updater.cc
index 2bd4e6b22fbd3e3928e1fd7eded5256230d817fe..cdc791a80b8511c6c07009f0dc005c0eedf0f053 100644
--- a/chrome/browser/extensions/extension_updater.cc
+++ b/chrome/browser/extensions/extension_updater.cc
@@ -313,12 +313,10 @@ void ManifestFetchesBuilder::AddPendingExtension(
   // Use a zero version to ensure that a pending extension will always
   // be updated, and thus installed (assuming all extensions have
   // non-zero versions).
-  scoped_ptr<Version> version(
-      Version::GetVersionFromString("0.0.0.0"));

[tfarina, 2011/08/31 21:18:40]

This is a TODO in base/version.cc to remove GetVersionFromString.

+  Version version("0.0.0.0");

[tfarina, 2011/08/31 21:18:40]

please, check if that is right. Do I need to call IsValid() here too?

[akalin, 2011/08/31 21:28:03]

I think so.  DCHECK(version.IsValid()); should suffice

[tfarina, 2011/08/31 21:35:36]

Done.

 
-  AddExtensionData(
-      info.install_source(), id, *version,
-      Extension::TYPE_UNKNOWN, info.update_url(), "");
+  AddExtensionData(info.install_source(), id, version,
+                   Extension::TYPE_UNKNOWN, info.update_url(), "");
 }
 
 void ManifestFetchesBuilder::ReportStats() const {