extensions: Use Version ctor instead of calling GetVersionFromString().

chrome/browser/extensions/extension_updater.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_updater.h"
 
 #include <algorithm>
 #include <set>
 
 #include "base/compiler_specific.h"
@@ skipping 295 matching lines @@
                    extension.GetType(),
                    extension.update_url(), update_url_data);
 }
 
 void ManifestFetchesBuilder::AddPendingExtension(
     const std::string& id,
     const PendingExtensionInfo& info) {
   // Use a zero version to ensure that a pending extension will always
   // be updated, and thus installed (assuming all extensions have
   // non-zero versions).
-  scoped_ptr<Version> version(
-      Version::GetVersionFromString("0.0.0.0"));

[tfarina, 2011/08/31 21:18:40]

This is a TODO in base/version.cc to remove GetVersionFromString.

+  Version version("0.0.0.0");

[tfarina, 2011/08/31 21:18:40]

please, check if that is right. Do I need to call IsValid() here too?

[akalin, 2011/08/31 21:28:03]

I think so.  DCHECK(version.IsValid()); should suffice

[tfarina, 2011/08/31 21:35:36]

Done.

 
-  AddExtensionData(
-      info.install_source(), id, *version,
-      Extension::TYPE_UNKNOWN, info.update_url(), "");
+  AddExtensionData(info.install_source(), id, version,
+                   Extension::TYPE_UNKNOWN, info.update_url(), "");
 }
 
 void ManifestFetchesBuilder::ReportStats() const {
   UMA_HISTOGRAM_COUNTS_100("Extensions.UpdateCheckExtension",
                            url_stats_.extension_count);
   UMA_HISTOGRAM_COUNTS_100("Extensions.UpdateCheckTheme",
                            url_stats_.theme_count);
   UMA_HISTOGRAM_COUNTS_100("Extensions.UpdateCheckApp",
                            url_stats_.app_count);
   UMA_HISTOGRAM_COUNTS_100("Extensions.UpdateCheckPending",
@@ skipping 910 matching lines @@
   std::set<std::string>::const_iterator i;
   for (i = ids.begin(); i != ids.end(); ++i)
     in_progress_ids_.insert(*i);
 }
 
 void ExtensionUpdater::RemoveFromInProgress(const std::set<std::string>& ids) {
   std::set<std::string>::const_iterator i;
   for (i = ids.begin(); i != ids.end(); ++i)
     in_progress_ids_.erase(*i);
 }