Issue 7820004: extensions: Use Version ctor instead of calling GetVersionFromString().

Issue 7820004: extensions: Use Version ctor instead of calling GetVersionFromString(). (Closed)

Created:
9 years, 3 months ago by tfarina

Modified:
9 years, 3 months ago

Reviewers:
cpu_(ooo_6.6-7.5), akalin

CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, mihaip+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

extensions: Use Version ctor instead of calling GetVersionFromString(). BUG=None TEST=None R=cpu@chromium.org,akalin@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=99374

Patch Set 2 : add DCHECK #

Total comments: 1

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -5 lines)			Patch
	M	chrome/browser/extensions/extension_updater.cc	View	1	1 chunk	+4 lines, -5 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

tfarina

http://codereview.chromium.org/7820004/diff/1/chrome/browser/extensions/extension_updater.cc File chrome/browser/extensions/extension_updater.cc (left): http://codereview.chromium.org/7820004/diff/1/chrome/browser/extensions/extension_updater.cc#oldcode317 chrome/browser/extensions/extension_updater.cc:317: Version::GetVersionFromString("0.0.0.0")); This is a TODO in base/version.cc to remove ...

9 years, 3 months ago (2011-08-31 21:18:40 UTC) #1

akalin

LGTM http://codereview.chromium.org/7820004/diff/1/chrome/browser/extensions/extension_updater.cc File chrome/browser/extensions/extension_updater.cc (right): http://codereview.chromium.org/7820004/diff/1/chrome/browser/extensions/extension_updater.cc#newcode316 chrome/browser/extensions/extension_updater.cc:316: Version version("0.0.0.0"); On 2011/08/31 21:18:40, tfarina wrote: > ...

9 years, 3 months ago (2011-08-31 21:28:02 UTC) #2

tfarina

http://codereview.chromium.org/7820004/diff/1/chrome/browser/extensions/extension_updater.cc File chrome/browser/extensions/extension_updater.cc (right): http://codereview.chromium.org/7820004/diff/1/chrome/browser/extensions/extension_updater.cc#newcode316 chrome/browser/extensions/extension_updater.cc:316: Version version("0.0.0.0"); On 2011/08/31 21:28:03, akalin wrote: > On ...

9 years, 3 months ago (2011-08-31 21:35:36 UTC) #3

cpu_(ooo_6.6-7.5)

9 years, 3 months ago (2011-09-01 02:11:32 UTC) #4

lgtm

http://codereview.chromium.org/7820004/diff/2003/chrome/browser/extensions/ex...
File chrome/browser/extensions/extension_updater.cc (right):

http://codereview.chromium.org/7820004/diff/2003/chrome/browser/extensions/ex...
chrome/browser/extensions/extension_updater.cc:317: DCHECK(version.IsValid());
that dcheck is checking a constant from the line before. Looks something that
goes into a unit test instead.

Expand Messages | Collapse Messages