Issue 7820001: Stop forward declaring WebKitClient.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7820001: Stop forward declaring WebKitClient. (Closed)

Created:
9 years, 3 months ago by abarth%chromium.org

Modified:
9 years, 3 months ago

Reviewers:
darin (slow to review), commit-bot: I haz the power, abarth-chromium

CC:
chromium-reviews, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Stop forward declaring WebKitClient. This forward declaration causes problems for the WebKitClient -> WebKitPlatformSupport rename. I'll change this back to a forward declaration once the rename is done. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=99030

Patch Set 1 #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	webkit/support/webkit_support.h	View		2 chunks	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

darin (slow to review)

LGTM Please remember that standalone WebKit pulls this directory via WebKit/chromium/DEPS.

9 years, 3 months ago (2011-08-31 19:50:55 UTC) #2

abarth-chromium

Yep. :) On Wed, Aug 31, 2011 at 12:50 PM, <darin@chromium.org> wrote: > LGTM > ...

9 years, 3 months ago (2011-08-31 19:52:22 UTC) #3

commit-bot: I haz the power

9 years, 3 months ago (2011-08-31 20:22:19 UTC) #4

Presubmit check for 7820001-1 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Messages **
If this change has an associated bug, add BUG=[bug number].

If this change requires manual test instructions to QA team, add
TEST=[instructions].

** Presubmit Warnings **
abarth%chromium.org@gtempaccount.com is not in AUTHORS file. If you are a new
contributor, please visit
http://www.chromium.org/developers/contributing-code and read the "Legal"
section
If you are a chromite, verify the contributor signed the CLA.

Presubmit checks took 5.2s to calculate.

Expand Messages | Collapse Messages