Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Unified Diff: chrome/browser/ssl/ssl_browser_tests.cc

Issue 7819009: For the SSL cert status, convert anonymous enum that gives bit values into a typedefed uint32. Th... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ssl/ssl_browser_tests.cc
===================================================================
--- chrome/browser/ssl/ssl_browser_tests.cc (revision 101367)
+++ chrome/browser/ssl/ssl_browser_tests.cc (working copy)
@@ -49,7 +49,8 @@
ASSERT_TRUE(entry);
EXPECT_EQ(NORMAL_PAGE, entry->page_type());
EXPECT_EQ(SECURITY_STYLE_AUTHENTICATED, entry->ssl().security_style());
- EXPECT_EQ(0, entry->ssl().cert_status() & net::CERT_STATUS_ALL_ERRORS);
+ EXPECT_EQ(net::CERT_STATUS_NO_ERROR,
+ entry->ssl().cert_status() & net::CERT_STATUS_ALL_ERRORS);
EXPECT_EQ(displayed_insecure_content,
entry->ssl().displayed_insecure_content());
EXPECT_FALSE(entry->ssl().ran_insecure_content());
@@ -60,13 +61,14 @@
ASSERT_TRUE(entry);
EXPECT_EQ(NORMAL_PAGE, entry->page_type());
EXPECT_EQ(SECURITY_STYLE_UNAUTHENTICATED, entry->ssl().security_style());
- EXPECT_EQ(0, entry->ssl().cert_status() & net::CERT_STATUS_ALL_ERRORS);
+ EXPECT_EQ(net::CERT_STATUS_NO_ERROR,
+ entry->ssl().cert_status() & net::CERT_STATUS_ALL_ERRORS);
EXPECT_FALSE(entry->ssl().displayed_insecure_content());
EXPECT_FALSE(entry->ssl().ran_insecure_content());
}
void CheckAuthenticationBrokenState(TabContents* tab,
- int error,
+ net::CertStatus error,
bool ran_insecure_content,
bool interstitial) {
NavigationEntry* entry = tab->controller().GetActiveEntry();

Powered by Google App Engine
This is Rietveld 408576698