For the SSL cert status, convert anonymous enum that gives bit values into a typedefed uint32. Th...

chrome/browser/ssl/ssl_error_info.h

Index: chrome/browser/ssl/ssl_error_info.h
===================================================================
--- chrome/browser/ssl/ssl_error_info.h	(revision 101367)
+++ chrome/browser/ssl/ssl_error_info.h	(working copy)
@@ -10,6 +10,7 @@
 #include <vector>
 
 #include "base/string16.h"
+#include "net/base/cert_status_flags.h"
 #include "net/base/x509_certificate.h"
 
 class GURL;
@@ -46,8 +47,8 @@
   // Populates the specified |errors| vector with the errors contained in
   // |cert_status|.  Returns the number of errors found.
   // Callers only interested in the error count can pass NULL for |errors|.

[wtc, 2011/09/21 23:54:25]

This comment is stale.  It should be updated to describe
the cert_id and request_url arguments.  You can just add
a TODO comment to note this.

[Peter Kasting, 2011/09/22 00:36:17]

Added TODO.

-  static int GetErrorsForCertStatus(int cert_status,
-                                    int cert_id,
+  static int GetErrorsForCertStatus(int cert_id,
+                                    net::CertStatus cert_status,
                                     const GURL& request_url,
                                     std::vector<SSLErrorInfo>* errors);

[wtc, 2011/09/21 23:54:25]

The CL's commit message should call out it is this function
that had the wrong-argument-order bug.

I verified that only this declaration had the arguments in the
wrong order.  Fortunately the function definition and its
callers have the arguments in the right order.

[Peter Kasting, 2011/09/22 00:36:17]

Done.