Add full support for filesystem URLs.

chrome/common/extensions/url_pattern.cc

Index: chrome/common/extensions/url_pattern.cc
diff --git a/chrome/common/extensions/url_pattern.cc b/chrome/common/extensions/url_pattern.cc
index c72f98cfea037dea5dc91f42eb2039577d86e76a..a7ee87d9b1e810a0f08f3d0d0a839d92dc28815e 100644
--- a/chrome/common/extensions/url_pattern.cc
+++ b/chrome/common/extensions/url_pattern.cc
@@ -153,6 +153,7 @@ URLPattern::ParseResult URLPattern::Parse(const std::string& pattern) {
   if (!SetScheme(pattern.substr(0, scheme_end_pos)))
     return PARSE_ERROR_INVALID_SCHEME;
 
+  // TODO(ericu): This will fail on filesystem URLs.  What should it do?

[Aaron Boodman, 2012/01/19 23:47:37]

Well, there aren't any places right now where we allow user-provided URLPatterns
to include filesystem:, so it's OK.

If we ever want users to be able to specify filesystem URLPatterns, then we'll
have to figure out what kind of syntax they would support and implement it here.

I guess this TODO can turn into:

TODO(ericu): Implement support for filesystem scheme?

   bool standard_scheme = IsStandardScheme(scheme_);
   if (standard_scheme != has_standard_scheme_separator)
     return PARSE_ERROR_WRONG_SCHEME_SEPARATOR;