Add full support for filesystem URLs.

chrome/common/extensions/url_pattern.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/extensions/url_pattern.h"
 
 #include "base/string_number_conversions.h"
 #include "base/string_piece.h"
 #include "base/string_split.h"
 #include "base/string_util.h"
@@ skipping 135 matching lines @@
     scheme_end_pos = pattern.find(':');
     has_standard_scheme_separator = false;
   }
 
   if (scheme_end_pos == std::string::npos)
     return PARSE_ERROR_MISSING_SCHEME_SEPARATOR;
 
   if (!SetScheme(pattern.substr(0, scheme_end_pos)))
     return PARSE_ERROR_INVALID_SCHEME;
 
+  // TODO(ericu): This will fail on filesystem URLs.  What should it do?

[Aaron Boodman, 2012/01/19 23:47:37]

Well, there aren't any places right now where we allow user-provided URLPatterns
to include filesystem:, so it's OK.

If we ever want users to be able to specify filesystem URLPatterns, then we'll
have to figure out what kind of syntax they would support and implement it here.

I guess this TODO can turn into:

TODO(ericu): Implement support for filesystem scheme?

   bool standard_scheme = IsStandardScheme(scheme_);
   if (standard_scheme != has_standard_scheme_separator)
     return PARSE_ERROR_WRONG_SCHEME_SEPARATOR;
 
   // Advance past the scheme separator.
   scheme_end_pos +=
       (standard_scheme ? strlen(chrome::kStandardSchemeSeparator) : 1);
   if (scheme_end_pos >= pattern.size())
     return PARSE_ERROR_EMPTY_HOST;
 
@@ skipping 323 matching lines @@
   }
 
   return result;
 }
 
 // static
 const char* URLPattern::GetParseResultString(
     URLPattern::ParseResult parse_result) {
   return kParseResultMessages[parse_result];
 }