Issue 7811002: Remove use of <iostream> where unnecessary.

Issue 7811002: Remove use of <iostream> where unnecessary. (Closed)

Created:
9 years, 3 months ago by Evan Martin

Modified:
9 years, 3 months ago

Reviewers:
brettw, DaveMoore, awong, Ami GONE FROM CHROMIUM, scherkus (not reviewing)

CC:
chromium-reviews, vrk (LEFT CHROMIUM), acolwell+watch_chromium.org, amit, annacc+watch_chromium.org, ajwong+watch_chromium.org, dhollowa, cbentzel+watch_chromium.org, dmaclach+watch_chromium.org, wez+watch_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org, kkania, ddorwin+watch_chromium.org, fischman+watch_chromium.org, simonmorris+watch_chromium.org, pam+watch_chromium.org, sergeyu+watch_chromium.org, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Remove use of <iostream> where unnecessary. Any file which uses <iostream> gains a static initializer, which is both disallowed by our style guide and also harms startup performance. Note that Chrome's logging.h uses <ostream> (note missing "i"), which includes the << operators for logging but does *not* use cin/cout. This is fine. BUG=94794 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=99237

Patch Set 1 #

Total comments: 1

Patch Set 2 : fixed #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -13 lines)			Patch
M	base/debug/debugger_posix.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	breakpad/pending/src/common/module.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/intents/web_intent_data.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/tools/ipclist/ipcfuzz.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome_frame/test/reliability/page_load_test.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	media/tools/shader_bench/shader_bench.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	net/base/gzip_filter_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	net/http/http_auth_filter_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	net/tools/flip_server/epoll_server.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	net/tools/flip_server/epoll_server.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	remoting/host/capturer_mac_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/gfx/transform_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	views/touchui/gesture_manager.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Ami GONE FROM CHROMIUM

http://codereview.chromium.org/7811002/diff/1/ppapi/examples/gles2/gles2.cc File ppapi/examples/gles2/gles2.cc (right): http://codereview.chromium.org/7811002/diff/1/ppapi/examples/gles2/gles2.cc#newcode7 ppapi/examples/gles2/gles2.cc:7: #include <ostream> This file uses std::cerr (it's a ppapi ...

9 years, 3 months ago (2011-08-31 18:04:12 UTC) #5

Evan Martin

9 years, 3 months ago (2011-08-31 21:48:31 UTC) #6

I used a sed script before.  Turned out I needed to be more careful and filter
out all files that mention cin/cout/cerr.  I will commit the subset of this
patch that passes the trybots.

Expand Messages | Collapse Messages