Add two command-line parameters and one bug fix for the layout test analyzer.

Add one commandline paramter and one bug fix for the layout test analyzer.

* Bug fix: fix the issue when there is some files with file names other than '%Y-%m-%d-%H' format in result directory. 
* Add two command-line parameter to choose test group CSV file and test group name. The example of such CSV file can be found in testname/media.csv. The test group name shows up in the status email subject. This is necessary to make this analyzer works for arbitrary test group name.
* minor doc change.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98883

[imasaki1, 2011-08-30 05:43:25]

Thank you.

[dennis_jeffrey, 2011-08-30 20:57:48]

http://codereview.chromium.org/7806008/diff/3001/media/tools/layout_tests/lay...
File media/tools/layout_tests/layouttest_analyzer.py (right):

http://codereview.chromium.org/7806008/diff/3001/media/tools/layout_tests/lay...
media/tools/layout_tests/layouttest_analyzer.py:86: layouttests =
LayoutTests(csv_file_path=os.path.join(
No need to call "os.path.join()" here, since that's already done at line 29
above.

http://codereview.chromium.org/7806008/diff/3001/media/tools/layout_tests/lay...
File media/tools/layout_tests/layouttest_analyzer_helpers.py (right):

http://codereview.chromium.org/7806008/diff/3001/media/tools/layout_tests/lay...
media/tools/layout_tests/layouttest_analyzer_helpers.py:268: bug_anno_map,
receiver_email_address, testname_group_name):
I think we can just call the variable "test_group_name" (no need to say "name"
twice in the variable name).

http://codereview.chromium.org/7806008/diff/3001/media/tools/layout_tests/lay...
media/tools/layout_tests/layouttest_analyzer_helpers.py:280:
testname_group_name: a name string of test name group such as 'media'.
test_group_name: string representing the test group name (e.g., 'media').

http://codereview.chromium.org/7806008/diff/3001/media/tools/layout_tests/lay...
media/tools/layout_tests/layouttest_analyzer_helpers.py:314: subject = 'Layout
Test Analyzer Result (%s) : %s' % (testname_group_name,
optional nit: remove the space right before the ':'

http://codereview.chromium.org/7806008/diff/3001/media/tools/layout_tests/lay...
media/tools/layout_tests/layouttest_analyzer_helpers.py:375: time_list: a list
of time string in the form of '2011-10-23-23'. Strings
Instead of giving only the example '2011-10-23-23' here, it might be better to
say what each field represents too, something like this:

'Year-Month-Day-Hour (e.g., 2011-10-23-23)'

http://codereview.chromium.org/7806008/diff/3001/media/tools/layout_tests/lay...
media/tools/layout_tests/layouttest_analyzer_helpers.py:376: in another format
are ignored.
'in another' -->
'not in this'

http://codereview.chromium.org/7806008/diff/3001/media/tools/layout_tests/lay...
media/tools/layout_tests/layouttest_analyzer_helpers.py:388: if latest_date ==
None or latest_date < item_date:
The goal of this function is to find the most recent time from a list, right? 
If so, then should the comparison here be reversed?

latest_date > item_date

According to python's datetime documentation, "datetime1 < datetime2 if
datetime1 precedes datetime2 in time".

[imasaki1, 2011-08-30 21:42:49]

On 2011/08/30 20:57:48, dennis_jeffrey wrote:
>
http://codereview.chromium.org/7806008/diff/3001/media/tools/layout_tests/lay...
> File media/tools/layout_tests/layouttest_analyzer.py (right):
> 
>
http://codereview.chromium.org/7806008/diff/3001/media/tools/layout_tests/lay...
> media/tools/layout_tests/layouttest_analyzer.py:86: layouttests =
> LayoutTests(csv_file_path=os.path.join(
> No need to call "os.path.join()" here, since that's already done at line 29
> above.
> 
>
http://codereview.chromium.org/7806008/diff/3001/media/tools/layout_tests/lay...
> File media/tools/layout_tests/layouttest_analyzer_helpers.py (right):
> 
>
http://codereview.chromium.org/7806008/diff/3001/media/tools/layout_tests/lay...
> media/tools/layout_tests/layouttest_analyzer_helpers.py:268: bug_anno_map,
> receiver_email_address, testname_group_name):
> I think we can just call the variable "test_group_name" (no need to say "name"
> twice in the variable name).
> 
>
http://codereview.chromium.org/7806008/diff/3001/media/tools/layout_tests/lay...
> media/tools/layout_tests/layouttest_analyzer_helpers.py:280:
> testname_group_name: a name string of test name group such as 'media'.
> test_group_name: string representing the test group name (e.g., 'media').
> 
>
http://codereview.chromium.org/7806008/diff/3001/media/tools/layout_tests/lay...
> media/tools/layout_tests/layouttest_analyzer_helpers.py:314: subject = 'Layout
> Test Analyzer Result (%s) : %s' % (testname_group_name,
> optional nit: remove the space right before the ':'
> 
>
http://codereview.chromium.org/7806008/diff/3001/media/tools/layout_tests/lay...
> media/tools/layout_tests/layouttest_analyzer_helpers.py:375: time_list: a list
> of time string in the form of '2011-10-23-23'. Strings
> Instead of giving only the example '2011-10-23-23' here, it might be better to
> say what each field represents too, something like this:
> 
> 'Year-Month-Day-Hour (e.g., 2011-10-23-23)'
> 
>
http://codereview.chromium.org/7806008/diff/3001/media/tools/layout_tests/lay...
> media/tools/layout_tests/layouttest_analyzer_helpers.py:376: in another format
> are ignored.
> 'in another' -->
> 'not in this'
> 
>
http://codereview.chromium.org/7806008/diff/3001/media/tools/layout_tests/lay...
> media/tools/layout_tests/layouttest_analyzer_helpers.py:388: if latest_date ==
> None or latest_date < item_date:
> The goal of this function is to find the most recent time from a list, right? 
> If so, then should the comparison here be reversed?
> 
> latest_date > item_date
> 
> According to python's datetime documentation, "datetime1 < datetime2 if
> datetime1 precedes datetime2 in time".

? I think it is working as intended.

[imasaki1, 2011-08-30 21:47:39]

Thanks. I addressed all issues except for the last one.

http://codereview.chromium.org/7806008/diff/3001/media/tools/layout_tests/lay...
File media/tools/layout_tests/layouttest_analyzer.py (right):

http://codereview.chromium.org/7806008/diff/3001/media/tools/layout_tests/lay...
media/tools/layout_tests/layouttest_analyzer.py:86: layouttests =
LayoutTests(csv_file_path=os.path.join(
On 2011/08/30 20:57:48, dennis_jeffrey wrote:
> No need to call "os.path.join()" here, since that's already done at line 29
> above.

Done.

http://codereview.chromium.org/7806008/diff/3001/media/tools/layout_tests/lay...
File media/tools/layout_tests/layouttest_analyzer_helpers.py (right):

http://codereview.chromium.org/7806008/diff/3001/media/tools/layout_tests/lay...
media/tools/layout_tests/layouttest_analyzer_helpers.py:268: bug_anno_map,
receiver_email_address, testname_group_name):
On 2011/08/30 20:57:48, dennis_jeffrey wrote:
> I think we can just call the variable "test_group_name" (no need to say "name"
> twice in the variable name).

Done.

http://codereview.chromium.org/7806008/diff/3001/media/tools/layout_tests/lay...
media/tools/layout_tests/layouttest_analyzer_helpers.py:280:
testname_group_name: a name string of test name group such as 'media'.
On 2011/08/30 20:57:48, dennis_jeffrey wrote:
> test_group_name: string representing the test group name (e.g., 'media').

Done.

http://codereview.chromium.org/7806008/diff/3001/media/tools/layout_tests/lay...
media/tools/layout_tests/layouttest_analyzer_helpers.py:314: subject = 'Layout
Test Analyzer Result (%s) : %s' % (testname_group_name,
On 2011/08/30 20:57:48, dennis_jeffrey wrote:
> optional nit: remove the space right before the ':'

Done.

http://codereview.chromium.org/7806008/diff/3001/media/tools/layout_tests/lay...
media/tools/layout_tests/layouttest_analyzer_helpers.py:375: time_list: a list
of time string in the form of '2011-10-23-23'. Strings
On 2011/08/30 20:57:48, dennis_jeffrey wrote:
> Instead of giving only the example '2011-10-23-23' here, it might be better to
> say what each field represents too, something like this:
> 
> 'Year-Month-Day-Hour (e.g., 2011-10-23-23)'

Done.

http://codereview.chromium.org/7806008/diff/3001/media/tools/layout_tests/lay...
media/tools/layout_tests/layouttest_analyzer_helpers.py:376: in another format
are ignored.
On 2011/08/30 20:57:48, dennis_jeffrey wrote:
> 'in another' -->
> 'not in this'

Done.

http://codereview.chromium.org/7806008/diff/3001/media/tools/layout_tests/lay...
media/tools/layout_tests/layouttest_analyzer_helpers.py:388: if latest_date ==
None or latest_date < item_date:
On 2011/08/30 20:57:48, dennis_jeffrey wrote:
> The goal of this function is to find the most recent time from a list, right? 
> If so, then should the comparison here be reversed?
> 
> latest_date > item_date
> 
> According to python's datetime documentation, "datetime1 < datetime2 if
> datetime1 precedes datetime2 in time".

? I think this is working as intended.

[dennis_jeffrey, 2011-08-30 22:49:07]

LGTM

Just one minor nit to address before submitting.  Thank you!

http://codereview.chromium.org/7806008/diff/3001/media/tools/layout_tests/lay...
File media/tools/layout_tests/layouttest_analyzer_helpers.py (right):

http://codereview.chromium.org/7806008/diff/3001/media/tools/layout_tests/lay...
media/tools/layout_tests/layouttest_analyzer_helpers.py:388: if latest_date ==
None or latest_date < item_date:
On 2011/08/30 21:47:39, imasaki1 wrote:
> On 2011/08/30 20:57:48, dennis_jeffrey wrote:
> > The goal of this function is to find the most recent time from a list,
right? 
> > If so, then should the comparison here be reversed?
> > 
> > latest_date > item_date
> > 
> > According to python's datetime documentation, "datetime1 < datetime2 if
> > datetime1 precedes datetime2 in time".
> 
> ? I think this is working as intended.

You're right - it is working as intended and there's also a unit test for this
case.  Sorry about that.

http://codereview.chromium.org/7806008/diff/7001/media/tools/layout_tests/lay...
File media/tools/layout_tests/layouttest_analyzer_helpers.py (right):

http://codereview.chromium.org/7806008/diff/7001/media/tools/layout_tests/lay...
media/tools/layout_tests/layouttest_analyzer_helpers.py:315: localtime)
indent this line by 1 fewer space