Add two command-line parameters and one bug fix for the layout test analyzer.

media/tools/layout_tests/layouttest_analyzer_helpers.py

 #!/usr/bin/python
 # Copyright (c) 2011 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Helper functions for the layout test analyzer."""
 
 import copy
 from datetime import datetime
 from email.mime.multipart import MIMEMultipart
@@ skipping 247 matching lines @@
             main_te_info[k] = True
         if 'Bugs' in te_info:
           for bug in te_info['Bugs']:
             if bug not in bug_map:
               bug_map[bug] = []
             bug_map[bug].append((name, main_te_info))
     return bug_map
 
 
 def SendStatusEmail(prev_time, analyzer_result_map, prev_analyzer_result_map,
-                    bug_anno_map, receiver_email_address):
+                    bug_anno_map, receiver_email_address, testname_group_name):

[dennis_jeffrey, 2011/08/30 20:57:48]

I think we can just call the variable "test_group_name" (no need to say "name"
twice in the variable name).

[imasaki1, 2011/08/30 21:47:39]

Done.

   """Send status email.
 
   Args:
     prev_time: the date string such as '2011-10-09-11'. This format has been
         used in this analyzer.
     analyzer_result_map: current analyzer result.
     prev_analyzer_result_map: previous analyzer result, which is read from
          a file.
     bug_anno_map: bug annotation map where bug name and annotations are
          stored.
     receiver_email_address: receiver's email address.
+    testname_group_name: a name string of test name group such as 'media'.

[dennis_jeffrey, 2011/08/30 20:57:48]

test_group_name: string representing the test group name (e.g., 'media').

[imasaki1, 2011/08/30 21:47:39]

Done.

   """
   diff_map = analyzer_result_map.CompareToOtherResultMap(
       prev_analyzer_result_map)
   str = analyzer_result_map.ConvertToString(prev_time, diff_map, bug_anno_map)
   # Add diff info about skipped/non-skipped test.
   prev_time = datetime.strptime(prev_time, '%Y-%m-%d-%H')
   prev_time = time.mktime(prev_time.timetuple())
   testname_map = {}
   for type in ['skip', 'nonskip']:
     for i in range(2):
@@ skipping 13 matching lines @@
                             'LayoutTests%2Fplatform%2Fchromium%2F'
                             'test_expectations.txt') % (new_rev, old_rev)
       str += '<ul><a href="%s">%s->%s</a>\n' % (link, old_rev, new_rev)
       str += '<li>%s</li>\n' % author
       str += '<li>%s</li>\n<ul>' % date
       for line in target_lines:
         str += '<li>%s</li>\n' % line
       str += '</ul></ul>'
   localtime = time.asctime(time.localtime(time.time()))
   # TODO(imasaki): remove my name from here.
+  subject = 'Layout Test Analyzer Result (%s) : %s' % (testname_group_name,

[dennis_jeffrey, 2011/08/30 20:57:48]

optional nit: remove the space right before the ':'

[imasaki1, 2011/08/30 21:47:39]

Done.

+                                                       localtime)
   SendEmail('imasaki@chromium.org', 'Kenji Imasaki',
-            [receiver_email_address], ['Layout Test Analyzer Result'],
-            'Layout Test Analyzer Result : ' + localtime, str)
+            [receiver_email_address], ['Layout Test Analyzer Result'], subject,
+            str)
 
 
 def SendEmail(sender_email_address, sender_name, receivers_email_addresses,
               receivers_names, subject, message):
     """Send email using localhost's mail server.
 
     Args:
         sender_email_address: sender's email address.
         sender_name: sender's name.
         receivers_email_addresses: receiver's email addresses.
@@ skipping 36 matching lines @@
       print 'Error: unable to send email'
 
 
 def FindLatestTime(time_list):
   """Find latest time from |time_list|.
 
   The current status is compared to the status of the latest file in
   |RESULT_DIR|.
 
   Args:
-    time_list: a list of time string in the form of '2011-10-23-23'.
+    time_list: a list of time string in the form of '2011-10-23-23'. Strings

[dennis_jeffrey, 2011/08/30 20:57:48]

Instead of giving only the example '2011-10-23-23' here, it might be better to
say what each field represents too, something like this:

'Year-Month-Day-Hour (e.g., 2011-10-23-23)'

[imasaki1, 2011/08/30 21:47:39]

Done.

+        in another format are ignored.

[dennis_jeffrey, 2011/08/30 20:57:48]

'in another' -->
'not in this'

[imasaki1, 2011/08/30 21:47:39]

Done.

 
   Returns:
      a string representing latest time among the time_list or None if
-         |time_list| is empty.
+         |time_list| is empty or no valid date string in |time_list|.
   """
   if not time_list:
     return None
   latest_date = None
   for t in time_list:
-    item_date = datetime.strptime(t, '%Y-%m-%d-%H')
-    if latest_date == None or latest_date < item_date:
-      latest_date = item_date
-  return latest_date.strftime('%Y-%m-%d-%H')
+    try:
+      item_date = datetime.strptime(t, '%Y-%m-%d-%H')
+      if latest_date == None or latest_date < item_date:

[dennis_jeffrey, 2011/08/30 20:57:48]

The goal of this function is to find the most recent time from a list, right? 
If so, then should the comparison here be reversed?

latest_date > item_date

According to python's datetime documentation, "datetime1 < datetime2 if
datetime1 precedes datetime2 in time".

[imasaki1, 2011/08/30 21:47:39]

? I think this is working as intended.

[dennis_jeffrey, 2011/08/30 22:49:07]

You're right - it is working as intended and there's also a unit test for this
case.  Sorry about that.

+        latest_date = item_date
+    except ValueError:
+      # Do nothing.
+      pass
+  if latest_date:
+    return latest_date.strftime('%Y-%m-%d-%H')
+  else:
+    return None
 
 
 def FindLatestResult(result_dir):
   """Find the latest result in |result_dir| and read and return them.
 
   This is used for comparison of analyzer result between current analyzer
   and most known latest result.
 
   Args:
     result_dir: the result directory.
@@ skipping 32 matching lines @@
           list2 = map2[name]['te_info']
           te_diff = [item for item in list1 if not item in list2]
           if te_diff:
               name_list.append((name, te_diff))
       else:
         name_list.append((name, v1))
     return name_list
 
   return (GetDiffBetweenMapsHelper(map1, map2, lookIntoTestExpectationInfo),
           GetDiffBetweenMapsHelper(map2, map1, lookIntoTestExpectationInfo))