Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issue 7803003: Merge 98292 - Show only one error notification per inserted mulitpartitioned usb card. (Closed)

Created:
9 years, 3 months ago by tbarzic
Modified:
9 years, 3 months ago
Reviewers:
tbarzic
CC:
chromium-reviews, Aaron Boodman, rginda+watch_chromium.org, achuith+watch_chromium.org, Erik does not do reviews, davemoore+watch_chromium.org
Visibility:
Public.

Description

Merge 98292 - Show only one error notification per inserted mulitpartitioned usb card. iWe should use system path of the device that contains partitions block device, instead partitions system path as notifications identification path. e.g. /sys/devices/pci0000:00/0000:00:1d.7/usb1/1-6/1-6:1.0/host9/target9:0:0/9:0:0:0 instead of /sys/devices/pci0000:00/0000:00:1d.7/usb1/1-6/1-6:1.0/host9/target9:0:0/9:0:0:0/block/sdb/sdb9 TEST=Manual on Cr48 (tried multiple-partitioned device with no good partitions, with one good-partition, device with one partition) BUG=chromium-os:19559 Review URL: http://codereview.chromium.org/7748003 TBR=tbarzic@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98838

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M chrome/browser/chromeos/extensions/file_browser_event_router.cc View 2 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
tbarzic
9 years, 3 months ago (2011-08-30 17:59:06 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698