Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 7748003: Show only one error notification per inserted mulitpartitioned usb card. (Closed)

Created:
9 years, 4 months ago by tbarzic
Modified:
9 years, 3 months ago
CC:
chromium-reviews, Erik does not do reviews, achuith+watch_chromium.org, mihaip+watch_chromium.org, Aaron Boodman, rginda+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Show only one error notification per inserted mulitpartitioned usb card. iWe should use system path of the device that contains partitions block device, instead partitions system path as notifications identification path. e.g. /sys/devices/pci0000:00/0000:00:1d.7/usb1/1-6/1-6:1.0/host9/target9:0:0/9:0:0:0 instead of /sys/devices/pci0000:00/0000:00:1d.7/usb1/1-6/1-6:1.0/host9/target9:0:0/9:0:0:0/block/sdb/sdb9 TEST=Manual on Cr48 (tried multiple-partitioned device with no good partitions, with one good-partition, device with one partition) BUG=chromium-os:19559 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98292

Patch Set 1 #

Patch Set 2 : "We can leave HideFileBrowserNotification calls as they were" #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M chrome/browser/chromeos/extensions/file_browser_event_router.cc View 1 2 chunks +5 lines, -2 lines 2 comments Download

Messages

Total messages: 5 (0 generated)
tbarzic
This is for a R14 Stable Blocker..
9 years, 4 months ago (2011-08-25 00:18:58 UTC) #1
zel
http://codereview.chromium.org/7748003/diff/2001/chrome/browser/chromeos/extensions/file_browser_event_router.cc File chrome/browser/chromeos/extensions/file_browser_event_router.cc (right): http://codereview.chromium.org/7748003/diff/2001/chrome/browser/chromeos/extensions/file_browser_event_router.cc#newcode214 chrome/browser/chromeos/extensions/file_browser_event_router.cc:214: disk->system_path().substr(0, disk->system_path().rfind("/block")); /block feels bit too platform specific. i.e. ...
9 years, 4 months ago (2011-08-25 13:50:47 UTC) #2
tbarzic
I am rewriting file browser notification code for m15 (should have cl up for review ...
9 years, 3 months ago (2011-08-25 16:48:26 UTC) #3
zel
LGTM
9 years, 3 months ago (2011-08-25 17:02:32 UTC) #4
commit-bot: I haz the power
9 years, 3 months ago (2011-08-25 20:43:37 UTC) #5
Change committed as 98292

Powered by Google App Engine
This is Rietveld 408576698