Jingle unit tests for issue 87336

jingle/notifier/base/proxy_resolving_client_socket.h

Index: jingle/notifier/base/proxy_resolving_client_socket.h
diff --git a/jingle/notifier/base/proxy_resolving_client_socket.h b/jingle/notifier/base/proxy_resolving_client_socket.h
index a651403f070d24a1dcbccf4724fa4e4debd51b54..d2d24d92427a9e308c0f3f792a384c1292c24bd3 100644
--- a/jingle/notifier/base/proxy_resolving_client_socket.h
+++ b/jingle/notifier/base/proxy_resolving_client_socket.h
@@ -21,6 +21,7 @@
 #include "net/socket/stream_socket.h"
 
 namespace net {
+class ClientSocketFactory;
 class ClientSocketHandle;
 class HttpNetworkSession;
 class URLRequestContextGetter;
@@ -32,10 +33,10 @@ namespace notifier {
 class ProxyResolvingClientSocket : public net::StreamSocket {
  public:
   ProxyResolvingClientSocket(
-    const scoped_refptr<net::URLRequestContextGetter>&
-        request_context_getter,
-    const net::SSLConfig& ssl_config,
-    const net::HostPortPair& dest_host_port_pair);
+      net::ClientSocketFactory* socket_factory,

[akalin, 2011/09/13 22:37:49]

add a comment explaining that you can pass in NULL for socket_factory, and doing
so implies using the default.

At least, that's what I'm assuming the behavior is, right?  It would be good to
sanity-check that.

[asanka, 2011/09/14 19:08:07]

Done.  And correct.  If socket_factory is NULL, we'll end up using
ClientSocketFactory::GetDefaultFactory().

+      const scoped_refptr<net::URLRequestContextGetter>& request_context_getter,
+      const net::SSLConfig& ssl_config,
+      const net::HostPortPair& dest_host_port_pair);
   virtual ~ProxyResolvingClientSocket();
 
   // net::StreamSocket implementation.