Jingle unit tests for issue 87336

jingle/notifier/base/proxy_resolving_client_socket.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // This StreamSocket implementation wraps a ClientSocketHandle that is created
 // from the client socket pool after resolving proxies.
 
 #ifndef JINGLE_NOTIFIER_BASE_PROXY_RESOLVING_CLIENT_SOCKET_H_
 #define JINGLE_NOTIFIER_BASE_PROXY_RESOLVING_CLIENT_SOCKET_H_
 #pragma once
 
 #include "base/basictypes.h"
 #include "base/memory/ref_counted.h"
 #include "net/base/completion_callback.h"
 #include "net/base/host_port_pair.h"
 #include "net/base/net_errors.h"
 #include "net/base/net_log.h"
 #include "net/base/ssl_config_service.h"
 #include "net/proxy/proxy_info.h"
 #include "net/proxy/proxy_service.h"
 #include "net/socket/stream_socket.h"
 
 namespace net {
+class ClientSocketFactory;
 class ClientSocketHandle;
 class HttpNetworkSession;
 class URLRequestContextGetter;
 }  // namespace net
 
 // TODO(sanjeevr): Move this to net/
 namespace notifier {
 
 class ProxyResolvingClientSocket : public net::StreamSocket {
  public:
   ProxyResolvingClientSocket(
-    const scoped_refptr<net::URLRequestContextGetter>&
-        request_context_getter,
-    const net::SSLConfig& ssl_config,
-    const net::HostPortPair& dest_host_port_pair);
+      net::ClientSocketFactory* socket_factory,

[akalin, 2011/09/13 22:37:49]

add a comment explaining that you can pass in NULL for socket_factory, and doing
so implies using the default.

At least, that's what I'm assuming the behavior is, right?  It would be good to
sanity-check that.

[asanka, 2011/09/14 19:08:07]

Done.  And correct.  If socket_factory is NULL, we'll end up using
ClientSocketFactory::GetDefaultFactory().

+      const scoped_refptr<net::URLRequestContextGetter>& request_context_getter,
+      const net::SSLConfig& ssl_config,
+      const net::HostPortPair& dest_host_port_pair);
   virtual ~ProxyResolvingClientSocket();
 
   // net::StreamSocket implementation.
   virtual int Read(net::IOBuffer* buf, int buf_len,
                    net::CompletionCallback* callback) OVERRIDE;
   virtual int Write(net::IOBuffer* buf, int buf_len,
                     net::CompletionCallback* callback) OVERRIDE;
   virtual bool SetReceiveBufferSize(int32 size) OVERRIDE;
   virtual bool SetSendBufferSize(int32 size) OVERRIDE;
   virtual int Connect(net::CompletionCallback* callback) OVERRIDE;
@@ skipping 39 matching lines @@
   ScopedRunnableMethodFactory<ProxyResolvingClientSocket>
       scoped_runnable_method_factory_;
 
   // The callback passed to Connect().
   net::CompletionCallback* user_connect_callback_;
 };
 
 }  // namespace notifier
 
 #endif  // JINGLE_NOTIFIER_BASE_PROXY_RESOLVING_CLIENT_SOCKET_H_