Jingle unit tests for issue 87336

Jingle unit tests for issue 87336

BUG=87336
TEST=jingle_unittests --gtest_filter=ProxyResolvingClientSocketTest.ReportsBadProxies


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=101303

[asanka, 2011-08-30 21:01:41]

This adds a unit test for proxy behavior added in
http://codereview.chromium.org/7532011/ .

[asanka, 2011-09-06 20:24:00]

Ping

[sanjeevr, 2011-09-06 22:02:38]

I would suggest that akalin review this.

[akalin, 2011-09-13 22:37:49]

LGTM

http://codereview.chromium.org/7802002/diff/2001/jingle/notifier/base/proxy_r...
File jingle/notifier/base/proxy_resolving_client_socket.h (right):

http://codereview.chromium.org/7802002/diff/2001/jingle/notifier/base/proxy_r...
jingle/notifier/base/proxy_resolving_client_socket.h:36:
net::ClientSocketFactory* socket_factory,
add a comment explaining that you can pass in NULL for socket_factory, and doing
so implies using the default.

At least, that's what I'm assuming the behavior is, right?  It would be good to
sanity-check that.

[asanka, 2011-09-14 19:08:06]

Thanks!

http://codereview.chromium.org/7802002/diff/2001/jingle/notifier/base/proxy_r...
File jingle/notifier/base/proxy_resolving_client_socket.h (right):

http://codereview.chromium.org/7802002/diff/2001/jingle/notifier/base/proxy_r...
jingle/notifier/base/proxy_resolving_client_socket.h:36:
net::ClientSocketFactory* socket_factory,
On 2011/09/13 22:37:49, akalin wrote:
> add a comment explaining that you can pass in NULL for socket_factory, and
doing
> so implies using the default.
> 
> At least, that's what I'm assuming the behavior is, right?  It would be good
to
> sanity-check that.

Done.  And correct.  If socket_factory is NULL, we'll end up using
ClientSocketFactory::GetDefaultFactory().

[commit-bot: I haz the power, 2011-09-15 16:31:37]

Change committed as 101303