Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Issue 7799005: Save Breakpad symbol files for main executable name variants (Closed)

Created:
9 years, 3 months ago by Mark Mentovai
Modified:
9 years, 3 months ago
Reviewers:
TVL
CC:
chromium-reviews, pam+watch_chromium.org
Visibility:
Public.

Description

Save Breakpad symbol files for main executable name variants. This allows symbolization of Google Chrome Canary, Google Chrome Helper EH, and Google Chrome Helper NP. The practical effect of this is that _main and start will be properly symbolized by Breakpad. BUG=94540 TEST=Look at the Breakpad crash reports for the canary browser process, plug-in process, and NaCl loader process. The bottom of each stack should show ChromeMain being called by main, which is in turn called by start. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98682

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -5 lines) Patch
M chrome/chrome_exe.gypi View 1 chunk +6 lines, -5 lines 0 comments Download
M chrome/tools/build/mac/dump_product_syms View 2 chunks +46 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Mark Mentovai
9 years, 3 months ago (2011-08-29 19:31:33 UTC) #1
TVL
9 years, 3 months ago (2011-08-29 20:00:41 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698