Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4324)

Unified Diff: chrome/chrome_exe.gypi

Issue 7799005: Save Breakpad symbol files for main executable name variants (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/tools/build/mac/dump_product_syms » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/chrome_exe.gypi
===================================================================
--- chrome/chrome_exe.gypi (revision 98647)
+++ chrome/chrome_exe.gypi (working copy)
@@ -387,11 +387,12 @@
# unnecessary for the "More Helpers" because they're identical
# to the original helper except for the bits in their Mach-O
# headers that change to enable or disable special features.
- # Each .dSYM and Breakpad symbol file is identified by UUID
- # stored in a Mach-O file's LC_UUID load command. Because the
- # "More Helpers" share a UUID with the original helper, there's
- # no need to run dsymutil or dump_syms again. All helpers can
- # share the same .dSYM and Breakpad symbol file.
+ # Each .dSYM is identified by UUID stored in a Mach-O file's
+ # LC_UUID load command. Because the "More Helpers" share a UUID
+ # with the original helper, there's no need to run dsymutil
+ # again. All helpers can share the same .dSYM. Special handling
+ # is performed in chrome/tools/build/mac/dump_product_syms to
+ # prepare their Breakpad symbol files.
'postbuild_name': 'Make More Helpers',
'action': [
'tools/build/mac/make_more_helpers.sh',
« no previous file with comments | « no previous file | chrome/tools/build/mac/dump_product_syms » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698