Issue 7795022: Merge 98285 - [Mac] Keep the page-info-bubble controller alive until done with layout.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7795022: Merge 98285 - [Mac] Keep the page-info-bubble controller alive until done with layout. (Closed)

Created:
9 years, 3 months ago by Scott Hess - ex-Googler

Modified:
9 years, 3 months ago

Reviewers:
Scott Hess - ex-Googler

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/branches/835/src/

Visibility:
Public.

Description

Merge 98285 - [Mac] Keep the page-info-bubble controller alive until done with layout. If the window is animating closed when a previously-posted PerformLayout task is fired, the last reference to the controller may be released while laying things out. Pin the controller down until the task is completed. BUG=90773 TEST=Monitor crash server for continued zombies. Review URL: http://codereview.chromium.org/7717027 TBR=shess@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98837

Patch Set 1 #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	chrome/browser/ui/cocoa/page_info_bubble_controller.mm	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages