Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 7717027: [Mac] Keep the page-info-bubble controller alive until done with layout. (Closed)

Created:
9 years, 4 months ago by Scott Hess - ex-Googler
Modified:
9 years, 4 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

[Mac] Keep the page-info-bubble controller alive until done with layout. If the window is animating closed when a previously-posted PerformLayout task is fired, the last reference to the controller may be released while laying things out. Pin the controller down until the task is completed. BUG=90773 TEST=Monitor crash server for continued zombies. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98285

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M chrome/browser/ui/cocoa/page_info_bubble_controller.mm View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Scott Hess - ex-Googler
I locally added code to log [controller_ retainCount] at entry and exit from PerformLayout(), and, ...
9 years, 4 months ago (2011-08-24 17:28:07 UTC) #1
Robert Sesek
LGTM
9 years, 4 months ago (2011-08-24 18:10:30 UTC) #2
commit-bot: I haz the power
9 years, 4 months ago (2011-08-25 20:27:42 UTC) #3
Change committed as 98285

Powered by Google App Engine
This is Rietveld 408576698