Issue 7795011: Fixing crash on sync when app becomes extension or vice versa.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7795011: Fixing crash on sync when app becomes extension or vice versa. (Closed)

Created:
9 years, 3 months ago by Ben Olmstead

Modified:
9 years, 3 months ago

Reviewers:
commit-bot: I haz the power, asargent_no_longer_on_chrome

CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, mihaip+watch_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Fixing crash on sync when app becomes extension or vice versa. BUG=94661 TEST=New unit test; also manually add a syncable app to profile, sync, then install extension with same ID: with change, no crash, without, crash on sync. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98860

Patch Set 1 #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+50 lines, -1 line)			Patch
	M	chrome/browser/extensions/extension_service.cc	View		2 chunks	+7 lines, -1 line	0 comments	Download
	M	chrome/browser/extensions/extension_service_unittest.cc	View		2 chunks	+43 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Ben Olmstead

This is the trunk patch that is equivalent to http://codereview.chromium.org/7744057/ It fixes the crash, but ...

9 years, 3 months ago (2011-08-29 22:38:51 UTC) #1

Change committed as 98860

Expand Messages | Collapse Messages