Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(503)

Issue 7744057: Do not attempt to apply app sync updates to extensions with matching ID, or vice versa. (Closed)

Created:
9 years, 4 months ago by Ben Olmstead
Modified:
9 years, 3 months ago
CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, Paweł Hajdan Jr., lipalani1
Visibility:
Public.

Description

Do not attempt to apply app sync updates to extensions with matching ID, or vice versa. BUG=chromium-os:19516 TEST=New unit test; also manually add a syncable app to profile, sync, then install extension with same ID: with change, no crash, without, crash on sync. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98662

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -0 lines) Patch
M chrome/browser/extensions/extension_service.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_service_unittest.cc View 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Ben Olmstead
This fixes a crash on sync when sync has data for an app with the ...
9 years, 4 months ago (2011-08-26 17:59:37 UTC) #1
asargent_no_longer_on_chrome
9 years, 4 months ago (2011-08-26 18:30:19 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698